Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI #6

Merged
merged 19 commits into from
Feb 19, 2020
Merged

Added CI #6

merged 19 commits into from
Feb 19, 2020

Conversation

JohanMabille
Copy link
Member

No description provided.

@SylvainCorlay
Copy link
Member

You may want to do

git update-index --add --chmod=+x io/travis/build-wheels.sh
git commit -m 'Make build-wheels.sh executable'
git push

@SylvainCorlay
Copy link
Member

weird, the scipt appears to be python3 only

@JohanMabille JohanMabille force-pushed the ci branch 3 times, most recently from 1952690 to b96b176 Compare February 11, 2020 09:17
@SylvainCorlay
Copy link
Member

Now we just need to install scikit-build in the docker.

@SylvainCorlay
Copy link
Member

Maybe a requirement-dev.txt listing skibuild would work. I don't know the minimal version of Python that supports it but all the python3 versions that we support have it.

@JohanMabille
Copy link
Member Author

It's already in it, I don't understand why it does not install skbuild when I install cmake first.

@JohanMabille JohanMabille force-pushed the ci branch 5 times, most recently from 8b526fa to 31c5581 Compare February 11, 2020 10:47
@SylvainCorlay
Copy link
Member

It does not seem that the nlohmann_json package provides a nlohmann_json target unfortunately, but a nlohmann::json one instead.

@JohanMabille
Copy link
Member Author

I think it does provide a nlohmann_json target, see its CMakeLists.txt. The find_package is not wrapped in the xtl, so the issue might come from here.

@SylvainCorlay
Copy link
Member

Ah, ok, I thought that it was an alias problem.

@JohanMabille JohanMabille force-pushed the ci branch 8 times, most recently from defa0bc to 5df93ed Compare February 13, 2020 15:09
@SylvainCorlay
Copy link
Member

Is our vendored openssl installed at all with scikit-build?

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Feb 18, 2020

Note: trying to build locally. I am seeing

make[4]: Leaving directory '/home/sylvain/dev/jupyter-xeus/xeus-python-wheel/_skbuild/linux-x86_64-3.7/cmake-build/libuuid-download/libuuid-src'
 /bin/mkdir -p '/usr/share/bash-completion/completions'
 /usr/bin/install -c -m 644 bash-completion/uuidgen '/usr/share/bash-completion/completions'
/usr/bin/install: cannot remove '/usr/share/bash-completion/completions/uuidgen': Permission denied

@JohanMabille
Copy link
Member Author

JohanMabille commented Feb 19, 2020

That is weird, I've never seen that locally. And the OpenSSL libraries are correctly installed (locally).

@SylvainCorlay
Copy link
Member

so we are missing a setup.py dependency to jedi?

@JohanMabille
Copy link
Member Author

JohanMabille commented Feb 19, 2020

and pygments. I'm adding them.

@JohanMabille JohanMabille force-pushed the ci branch 5 times, most recently from 3c9e615 to fea70ce Compare February 19, 2020 21:03
@JohanMabille JohanMabille merged commit fe646df into jupyter-xeus:master Feb 19, 2020
@JohanMabille JohanMabille deleted the ci branch February 19, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants