Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade singleuser.py for JupyterHub 3 #251

Closed

Conversation

mahendrapaipuri
Copy link
Contributor

The _api_request method of HubAuth in JupyterHub 3 is made into a coroutine. So, batchspawner-singleuser in its current implementation will fail to communicate with JupyterHub as request is never awaited.

This PR modifies the singleuser.py function to make it work for JupyterHub 2 and 3.

API request method of HubAuth in JupyterHub 3 changed to coroutine

Singleuser script is modified appropriately to make it work with JupyterHub 3
@welcome
Copy link

welcome bot commented Nov 24, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@loikki
Copy link

loikki commented Nov 30, 2022

Thanks, it solved my issue.

@mahendrapaipuri
Copy link
Contributor Author

In fact, this PR is more elegant solution than what I proposed here. I havent seen it before submitting this PR.

@ryanlovett I think we need to merge #247 into main and make a new release as JupyterHub 3.0.0 has been already around for few months.

@gridley
Copy link

gridley commented Feb 22, 2023

Awesome!! I was wrestling to get jupyterhub to work with slurm on my cluster forever, and this fixed it for me. Thank you! 😄

@mbmilligan
Copy link
Member

#247 was merged which addresses the same issue, so closing this PR. Thank you for the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants