Upgrade singleuser.py to JupyterHub 4 #267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jupyterhub-singleuser
is a subclass ofExtensionApp
and after a brief discussion with @minrk at JupyterCon, he told me that the new implementation ofjupyterhub-singleuser
does not expect any CLI args. If we usebatchspawner
with JupyterHub 4, we end up getting an error as follows:The
JUPYTERHUB_SERVICE_URL
env var is set tohttp(s)://0.0.0.0:0/user/<user>/servers/<server>
at the spawn time inbatchspawner
and due to this code here, depending on the HTTP scheme, the server will be either launched on 80/443 ports.This PR replaces the port in
JUPYTERHUB_SERVICE_URL
with free port that we find and updates the env var. Consequently, CLI arg--port
is removed as it is not used anymore.