Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes with latest RuboCop #459

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Fixes with latest RuboCop #459

merged 4 commits into from
Dec 28, 2021

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 27, 2021 •
edited
Loading

Some trivial RuboCop fixes and adjustments:

  • Removed exceptions to cops that were not active
  • RuboCop fixes for the specs

@excpt excpt self-requested a review December 27, 2021 21:10
excpt
excpt approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup :)

@anakinj anakinj merged commit fcf7bd2 into jwt:master Dec 28, 2021
@anakinj anakinj deleted the rubocop-fixes branch December 28, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excpt excpt excpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakinj @excpt