Removes images in k0s config create by default

[juanluisvaladas]

Fixes #2587

Signed-off-by: Juan Luis de Sousa-Valadas Castaño [email protected]

Description

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

• Manual test
• Auto test added

Checklist:

• My code follows the style guidelines of this project
• My commit messages are signed-off
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[juanluisvaladas]

Default behavior:

$ ./k0s config create --include-images | grep images:
  images:

With flag:

$ ./k0s config create --include-images | grep images: -A33
  images:
    calico:
      cni:
        image: docker.io/calico/cni
        version: v3.24.5
      kubecontrollers:
        image: docker.io/calico/kube-controllers
        version: v3.24.5
      node:
        image: docker.io/calico/node
        version: v3.24.5
    coredns:
      image: docker.io/coredns/coredns
      version: 1.10.0
    default_pull_policy: IfNotPresent
    konnectivity:
      image: quay.io/k0sproject/apiserver-network-proxy-agent
      version: 0.0.33-k0s
    kubeproxy:
      image: registry.k8s.io/kube-proxy
      version: v1.26.1
    kuberouter:
      cni:
        image: docker.io/cloudnativelabs/kube-router
        version: v1.5.1
      cniInstaller:
        image: quay.io/k0sproject/cni-node
        version: 1.1.1-k0s.0
    metricsserver:
      image: registry.k8s.io/metrics-server/metrics-server
      version: v0.6.2
    pushgateway:
      image: quay.io/k0sproject/pushgateway-ttl
      version: edge@sha256:7031f6bf6c957e2fdb496161fe3bea0a5bde3de800deeba7b2155187196ecbd9

[twz123]

I was under the impression that only the versions should be suppressed, not the whole images field. Despite that, LGTM.

[twz123]

Are there any other places in the docs that list all the images that k0s will use? I wonder if it would make sense to have some place in the docs where they're listed.

[juanluisvaladas]

I was under the impression that only the versions should be suppressed, not the whole images field. Despite that, LGTM.

The problem with that approach is that if we change the image we will have the same problem, and we don't host most of the images so it's an added risk.

[twz123]

The problem with that approach is that if we change the image we will have the same problem, and we don't host most of the images so it's an added risk.

Hmm, you're right. Although, in contrast to the image versions, the image names are quite stable.