[FEATURE] BREAKING: default port mappings via Loadbalancer + new nodefilter syntax #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
added
enhancement
iwilltry42
force-pushed
the
breaking/port-default-lb
branch
2 times, most recently
from
7470995 to
85c9db3
Compare
- generate node names when transforming from simple to cluster config - ClusterCreate(clusterconfig) should have a ready made config and not generate variables - ClusterCreate() only prep LB if not already present (to be removed) - cluster struct: serverloadbalancer is now of type LoadBalancer (Node + Config) - use new nodefilter syntax with 'id:index:suffix' instead of 'id[index]' everywhere - use suffix when creating the LB
iwilltry42
force-pushed
the
breaking/port-default-lb
branch
from
85c9db3 to
94d2792
Compare
…gs which should default to all nodes as upstream
…th control characters when checking the lb config
… all servers & agents as upstream
iwilltry42
changed the title
somaritane
referenced
this pull request
in AbsaOSS/k3d-action
Nov 15, 2021
- k3d config examples migrated to `apiVersion: k3d.io/v1alpha3` [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - `:direct` node filter option used when load balancer is disabled [https://github.com/rancher/k3d/pull/656](https://github.com/rancher/k3d/pull/656) - `--label` --> `--runtime-label` [https://github.com/rancher/k3d/pull/598](https://github.com/rancher/k3d/pull/598) - `--k3s-server-arg` --> `--k3s-arg` with server node filter (`@server:*`) [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - Updated documentation Signed-off-by: Timofey Ilinykh <[email protected]>
somaritane
referenced
this pull request
in AbsaOSS/k3d-action
Nov 15, 2021
- k3d config examples migrated to `apiVersion: k3d.io/v1alpha3` [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - `:direct` node filter option used when load balancer is disabled [https://github.com/rancher/k3d/pull/656](https://github.com/rancher/k3d/pull/656) - `--label` --> `--runtime-label` [https://github.com/rancher/k3d/pull/598](https://github.com/rancher/k3d/pull/598) - `--k3s-server-arg` --> `--k3s-arg` with server node filter (`@server:*`) [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - Updated documentation Signed-off-by: Timofey Ilinykh <[email protected]>
somaritane
referenced
this pull request
in AbsaOSS/k3d-action
Nov 16, 2021
- k3d config examples migrated to `apiVersion: k3d.io/v1alpha3` [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - `:direct` node filter option used when load balancer is disabled [https://github.com/rancher/k3d/pull/656](https://github.com/rancher/k3d/pull/656) - `--label` --> `--runtime-label` [https://github.com/rancher/k3d/pull/598](https://github.com/rancher/k3d/pull/598) - `--k3s-server-arg` --> `--k3s-arg` with server node filter (`@server:*`) [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - removed `disableImageVolume` option from examples and test assets - Updated documentation Signed-off-by: Timofey Ilinykh <[email protected]>
somaritane
referenced
this pull request
in AbsaOSS/k3d-action
Nov 16, 2021
- k3d config examples migrated to `apiVersion: k3d.io/v1alpha3` [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - `:direct` node filter option used when load balancer is disabled [https://github.com/rancher/k3d/pull/656](https://github.com/rancher/k3d/pull/656) - `--label` --> `--runtime-label` [https://github.com/rancher/k3d/pull/598](https://github.com/rancher/k3d/pull/598) - `--k3s-server-arg` --> `--k3s-arg` with server node filter (`@server:*`) [https://github.com/rancher/k3d/pull/605](https://github.com/rancher/k3d/pull/605) - removed `disableImageVolume` option from examples and test assets - Updated documentation Signed-off-by: Timofey Ilinykh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #652
To-Do
--port 1234:4321@loadbalancer:0:proxy(loadbalancer identifier does not work with indexing or opts)all:proxythe default nodefilter for--port