Upgrade: metrics server version bump from v0.5.0 to v0.5.2 #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Don't forget about the image list at https://github.com/k3s-io/k3s/blob/master/scripts/airgap/image-list.txt |
|
This ended up needing more involved fixes to track the upstream manifest changes that come with updating the image. I've pushed to your branch, and will backport to older branches. |
brandond
approved these changes
Jan 14, 2022
briandowns
approved these changes
Jan 14, 2022
This was referenced Jan 14, 2022
Kubernetes Metrics Server version upgrade with the following changes: Remove elevated permissions cap_net_bind_service from metrics-server Fix bad architecture metadata Fix reporting inconsistent number of nodes, caused by using invalid Kubelet node start time metric Fix reporting partial container metrics for pod Signed-off-by: Farukh Khan <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4867 +/- ##
==========================================
- Coverage 10.52% 10.45% -0.08%
==========================================
Files 142 142
Lines 10250 10323 +73
==========================================
Hits 1079 1079
- Misses 8943 9016 +73
Partials 228 228
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
cap_net_bind_servicefrom metrics-server (Cherrypick pull request #884 from shuaich/remove_elevated_permission to release-0.5 kubernetes-sigs/metrics-server#887)Types of Changes
Bugfix
Verification
v0.5.2
Linked Issues
User-Facing Change
Further Comments
The upgraded version of metrics server is a good to have in the latest releases of k3s because it fixes one elevated permissions security issue along with some minor bug fixes.