Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RegExp UTF-16 Matching #226

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

lemueldls
Copy link
Contributor

The crate used to evaluate regexp, regress, fixed the utf-16 matching problems in their 0.10.3 release.

The RegExp::exec function now correctly matches using utf-16 instead of utf-8.

Before (main):

snapshot_2025-01-31_10-36-01

After (regexp-utf16):

snapshot_2025-01-31_10-38-35

Expected:

snapshot_2025-01-31_10-45-05

@kaleidawave
Copy link
Owner

Awesome! Will look at merging next week.

@kaleidawave
Copy link
Owner

PR looks good (CI red unrelated). Nice to be more correct, good to see regress supports this. Thanks for cross-referencing the behaviour in runtimes.

@kaleidawave kaleidawave merged commit eeec0f8 into kaleidawave:main Feb 5, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants