Assorted time, seek, and performance fixes. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Live edge changed to 2 segments not 4. Fix for crash with null index handler. Fixed issue with incorrect time reporting for five seconds after seek. Fixed issue where calculating live edge would make seeks extremely slow. Fixed issue where seeks would always be to end of segment before live edge, not beginning of segment containing live edge. Fixed issue where tag slightly out of order at start of some streams caused corrupt playback. Fixed time wrap issue in PES Processor and HLS index handler causing incorrect timing as it tried to use 0 as a reference value when NaN reference value was more inappropriate. Get live edge from target quality to appropriately handle bitrate changes. More aggressively close best effort fetches. Refactored getSegmentsForQuality for legibility.
einatr
added a commit
that referenced
this pull request
Dec 6, 2015
Assorted time, seek, and performance fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live edge changed to 2 segments not 4.
Fix for crash with null index handler.
Fixed issue with incorrect time reporting for five seconds after seek.
Fixed issue where calculating live edge would make seeks extremely slow.
Fixed issue where seeks would always be to end of segment before live
edge, not beginning of segment containing live edge.
Fixed issue where tag slightly out of order at start of some streams
caused corrupt playback.
Fixed time wrap issue in PES Processor and HLS index handler causing
incorrect timing as it tried to use 0 as a reference value when NaN
reference value was more inappropriate.
Get live edge from target quality to appropriately handle bitrate
changes.
More aggressively close best effort fetches.
Refactored getSegmentsForQuality for legibility.