Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use fragment expression #2368

Merged
merged 1 commit into from
Jul 26, 2023
Merged

chore: use fragment expression #2368

merged 1 commit into from
Jul 26, 2023

Conversation

dersvenhesse
Copy link
Contributor

@dersvenhesse dersvenhesse commented Jul 25, 2023 •
edited
Loading

Running karate with current thymeleaf versions generates a warning:

org.thymeleaf.standard.processor.AbstractStandardFragmentInsertionTagProcessor","msg":"[THYMELEAF][main][karate-summary.html] Deprecated unwrapped fragment expression \"karate-leftnav.html\" found in template karate-summary.html, line 28, col 14. Please use the complete syntax of fragment expressions instead (\"~{karate-leftnav.html}\"). The old, unwrapped syntax for fragment expressions will be removed in future versions of Thymeleaf.

This PR does as suggested and uses a fragment expression to include thekarate-leftnav.

  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@ptrthomas ptrthomas merged commit c5442f3 into karatelabs:develop Jul 26, 2023
@dersvenhesse dersvenhesse mentioned this pull request Jul 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dersvenhesse @ptrthomas