Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user profile view #36

Merged
merged 18 commits into from
Feb 15, 2025
Merged

Add user profile view #36

merged 18 commits into from
Feb 15, 2025

Conversation

Kurocifer
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11576941048

Details

  • 28 of 290 (9.66%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-10.3%) to 39.884%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sabitou_clients/lib/routes/pages_routes.dart 0 2 0.0%
sabitou_clients/lib/routes/app_routes.dart 0 3 0.0%
sabitou_clients/lib/widgets/base_page.dart 18 21 85.71%
sabitou_clients/lib/services/internationalization/internationalization.dart 0 30 0.0%
sabitou_clients/lib/screens/profile/profile_view.dart 10 234 4.27%
Totals Coverage Status
Change from base Build 11421209661: -10.3%
Covered Lines: 483
Relevant Lines: 1211
💛 - Coveralls

warrenrhodes
warrenrhodes approved these changes Oct 18, 2024
View reviewed changes
@warrenrhodes warrenrhodes self-requested a review October 18, 2024 20:18
@Kurocifer
Copy link
Contributor Author

Kurocifer commented Oct 18, 2024 •
edited
Loading

Thanks for this Sir let me fix them

@Kurocifer
Add lost translations
10d05e5 
Add the translations the where removed during rebase
@Kurocifer
format files
89595db
@Kurocifer
Uncomment web build
9e727fe
@Kurocifer
Solve failing checks.
5fe1e35 
- Comment invalit import which made build-web check to fail.
- New implementation of golden test for ProfileView, to make the other
  checks to pass.
@warrenrhodes
Copy link
Contributor

You can follow this instruction to start the server and create the user.
https://github.com/karibu-cap/sabitou-clients/blob/main/server/README.MD

@warrenrhodes warrenrhodes self-requested a review October 21, 2024 21:45
@Kurocifer
Copy link
Contributor Author

Please @warrenrhodes
I don't really understand how I will get to use the user from grpc into this profile view as the fields are nullable, and when I try to use null assertion it does not let me to.

For the starting of the server and creating the user I don't really get how to get about it. Tried to get to the link on in that README be it won't load and the docker command too tells me it can't find the file.

For the other changes I've applied them.

@warrenrhodes
Copy link
Contributor

warrenrhodes commented Oct 22, 2024 •
edited
Loading

Please @warrenrhodes I don't really understand how I will get to use the user from grpc into this profile view as the fields are nullable, and when I try to use null assertion it does not let me to.

For the starting of the server and creating the user I don't really get how to get about it. Tried to get to the link on in that README be it won't load and the docker command too tells me it can't find the file.

For the other changes I've applied them.

@Kurocifer OK let's Organise a meet tomorrow. i will show you how to setup.

@Kurocifer
Copy link
Contributor Author

Please @warrenrhodes I don't really understand how I will get to use the user from grpc into this profile view as the fields are nullable, and when I try to use null assertion it does not let me to.
For the starting of the server and creating the user I don't really get how to get about it. Tried to get to the link on in that README be it won't load and the docker command too tells me it can't find the file.
For the other changes I've applied them.

@Kurocifer OK let's Organise a meet tomorrow. i will show you how to setup.

Okay is 4 pm okay ?

@warrenrhodes
Copy link
Contributor

warrenrhodes commented Oct 23, 2024 •
edited
Loading

Please @warrenrhodes I don't really understand how I will get to use the user from grpc into this profile view as the fields are nullable, and when I try to use null assertion it does not let me to.
For the starting of the server and creating the user I don't really get how to get about it. Tried to get to the link on in that README be it won't load and the docker command too tells me it can't find the file.
For the other changes I've applied them.

@Kurocifer OK let's Organise a meet tomorrow. i will show you how to setup.

Okay is 4 pm

start installing Docker compose and Docker

@Kurocifer
Add changes indicated in review
3a1b65a 
- Use user from the fake server.
- Add spacing between the user's personal info and the text above them.
@Tadjaur Tadjaur merged commit 882bd30 into main Feb 15, 2025
14 checks passed
@Tadjaur Tadjaur deleted the add-profile-view branch February 15, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tadjaur Tadjaur Tadjaur approved these changes

@nidovic nidovic Awaiting requested review from nidovic

@Fabrice-mokfembam2 Fabrice-mokfembam2 Awaiting requested review from Fabrice-mokfembam2

@warrenrhodes warrenrhodes Awaiting requested review from warrenrhodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kurocifer @coveralls @warrenrhodes @Tadjaur