runtime-rs: enable hugepage #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-0731-Hzt
added
do-not-merge
Tim-0731-Hzt
added a commit
to Tim-0731-Hzt/tests
that referenced
this pull request
Nov 7, 2022
Fixes:kata-containers#5242 Depends-on: github.com/kata-containers/kata-containers#5601 Signed-off-by: Zhongtao Hu <[email protected]>
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
84af78e to
84c70ed
Compare
Tim-0731-Hzt
added a commit
to Tim-0731-Hzt/tests
that referenced
this pull request
Nov 8, 2022
Fixes:kata-containers#5242 Depends-on: github.com/kata-containers/kata-containers#5601 Signed-off-by: Zhongtao Hu <[email protected]>
Tim-0731-Hzt
added a commit
to Tim-0731-Hzt/tests
that referenced
this pull request
Nov 8, 2022
Fixes:kata-containers#5242 Depends-on: github.com/kata-containers/kata-containers#5601 Signed-off-by: Zhongtao Hu <[email protected]>
Tim-0731-Hzt
force-pushed
the
hugepage
branch
4 times, most recently
from
a35cab8 to
b48c557
Compare
Tim-0731-Hzt
removed
do-not-merge
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
b48c557 to
b882ffc
Compare
xyjixyjixyji
suggested changes
Nov 10, 2022
Tim-0731-Hzt
force-pushed
the
hugepage
branch
2 times, most recently
from
e7fae46 to
78b3178
Compare
Tim-0731-Hzt
force-pushed
the
hugepage
branch
2 times, most recently
from
1d13836 to
b85eb93
Compare
Tim-0731-Hzt
added a commit
to Tim-0731-Hzt/tests
that referenced
this pull request
Nov 28, 2022
Fixes:kata-containers#5242 Depends-on: github.com/kata-containers/kata-containers#5601 Signed-off-by: Zhongtao Hu <[email protected]>
|
/test |
quanweiZhou
reviewed
Nov 28, 2022
src/runtime-rs/crates/runtimes/virt_container/src/container_manager/container.rs
Show resolved
Hide resolved
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
b85eb93 to
1368321
Compare
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
1368321 to
e055249
Compare
|
/test |
|
/test-arm |
quanweiZhou
approved these changes
Dec 6, 2022
YushuoEdge
reviewed
Dec 8, 2022
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
e055249 to
68b015e
Compare
support vm hugepage,set the hugetlbfs mount point as vm memory path Fixes:kata-containers#5560 Signed-off-by: Zhongtao Hu <[email protected]>
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
68b015e to
f49d83c
Compare
|
/test |
YushuoEdge
reviewed
Dec 9, 2022
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
f49d83c to
a107158
Compare
|
/test |
studychao
reviewed
Dec 12, 2022
| } | ||
| } | ||
|
|
||
| pub(crate) fn get_huge_page_option(m: &oci::Mount) -> Result<Option<Vec<String>>> { |
There was a problem hiding this comment.
If the hugetlbfs mount point is not mounted, will runtime help do that?
There was a problem hiding this comment.
or do we assume that when users are using this feature, they have already set up the environment for hugetlbfs?
There was a problem hiding this comment.
Yes, we assume the users will set up the environment for hugetlbfs. Because kubernetes will be responsible to check the environment on the host. So, if it isn't mounted, it will fail in kubelet.
| impl Hugepage { | ||
| pub(crate) fn new( | ||
| mount: &oci::Mount, | ||
| hugepage_limits_map: HashMap<Byte, u64>, |
There was a problem hiding this comment.
Also, why use Byte here? I see in go version it is using str
There was a problem hiding this comment.
I think Byte is more straightforward for page size, compared with str.
enable the functionality of using hugepages in container Fixes: kata-containers#5560 Signed-off-by: Zhongtao Hu <[email protected]>
Tim-0731-Hzt
force-pushed
the
hugepage
branch
from
a107158 to
afaf17f
Compare
|
/test |
|
/test-ubuntu |
Tim-0731-Hzt
added a commit
to Tim-0731-Hzt/tests
that referenced
this pull request
Dec 17, 2022
add hugepage test Fixes:kata-containers#5242 Depends-on: github.com/kata-containers/kata-containers#5601 Signed-off-by: Zhongtao Hu <[email protected]>
studychao
reviewed
Dec 25, 2022
| // /dev/hugepages will be the mount point | ||
| // mkdir -p /dev/hugepages | ||
| // mount -t hugetlbfs none /dev/hugepages | ||
| const DEV_HUGEPAGES: &str = "/dev/hugepages"; |
There was a problem hiding this comment.
You assume the mount point could only be /dev/hugepages here. Could this be configurable?
Is this behaviour the same in Go runtime?
There was a problem hiding this comment.
Yes, you can refer to this https://github.com/kata-containers/kata-containers/blob/main/src/runtime/pkg/govmm/qemu/qemu.go#L2848
dborquez
pushed a commit
to dborquez/kata-containers
that referenced
this pull request
Jun 5, 2023
This PR adds the http_proxy and https_proxy variables to the docker build arguments in order to avoid failures when building the images behind a proxy. Fixes kata-containers#5601 Signed-off-by: Gabriela Cervantes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable the functionality of using hugepages in container
Fixes: #5560
Signed-off-by: Zhongtao Hu [email protected]