Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed service account patch string format #111

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

lili-wan
Copy link
Contributor

@lili-wan lili-wan commented Feb 1, 2023

Signed-off-by: lwan3 [email protected]

Related to issue #107, the patch string was not in correct format so it failed silently.

Could you share the solution in high level?

Could you share the test results?
Before patching the annotation

k get sa default -o yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  creationTimestamp: "2023-01-13T05:34:49Z"
  name: default
  namespace: dev-iksmanager-usw2-ldev
  resourceVersion: "1590303619"
  uid: 1889a858-f860-4565-b600-7cacc984fa1a
secrets:
- name: default-token-slnmb

After patching the annoation

k get sa default -o yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::000065563193:role/k8s-dev-iksmanager-usw2-ldev
    eks.amazonaws.com/sts-regional-endpoints: "true"
  creationTimestamp: "2023-01-13T05:34:49Z"
  name: default
  namespace: dev-iksmanager-usw2-ldev
  resourceVersion: "1641569213"
  uid: 1889a858-f860-4565-b600-7cacc984fa1a
secrets:
- name: default-token-slnmb

@lili-wan lili-wan requested a review from a team as a code owner February 1, 2023 23:25
@lili-wan lili-wan self-assigned this Feb 1, 2023
Copy link

@figo figo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lili-wan lili-wan merged commit b41a855 into keikoproj:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants