3 phase high voltage inverter support #218

rixxxx · 2023-12-29T13:30:28Z

This is tested and working with Deye 20kw 3phase HV inverter(SUN-20K-SG01-HP3-EU-AM2).

codecov · 2023-12-29T20:06:32Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8d1fe76) 71.28% compared to head (9da7b0e) 72.09%.
Report is 7 commits behind head on main.

Files	Patch %	Lines
src/ha_addon_sunsynk_multi/sensor_options.py	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   71.28%   72.09%   +0.81%     
==========================================
  Files          23       24       +1     
  Lines        1689     1749      +60     
==========================================
+ Hits         1204     1261      +57     
- Misses        485      488       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rixxxx · 2023-12-29T20:19:44Z

sorry for the mess I created with the commits while trying to fixup a style issue black didn't like

kellerza

Thank you @rixxxx !

This looks really good, some minor comments.

kellerza · 2023-12-30T04:15:08Z

hass-addon-sunsynk-multi/config.yaml

@@ -58,7 +58,7 @@ schema:
      MODBUS_ID: int(1,16)
      DONGLE_SERIAL_NUMBER: int?
      PORT: str
-  SENSOR_DEFINITIONS: list(single-phase|three-phase)
+  SENSOR_DEFINITIONS: list(single-phase|three-phase|three-phase-hv)


Can you undo this change for now? Then we can release it on edge and test it for a while

(Changing multi's config without updating the version & tagging it causes inconsistencies between the addon's options & the built container)

kellerza · 2023-12-30T04:17:22Z

src/sunsynk/definitions3phhv.py

+    1: "On",
+}
+
+# PROG_CHARGE_OPTIONS = {


Please remove these commented lines

kellerza · 2023-12-30T04:17:34Z

src/sunsynk/definitions3phhv.py

+    SelectRWSensor(175, "Prog4 charge", options=PROG_CHARGE_OPTIONS),
+    SelectRWSensor(176, "Prog5 charge", options=PROG_CHARGE_OPTIONS),
+    SelectRWSensor(177, "Prog6 charge", options=PROG_CHARGE_OPTIONS),
+    # SelectRWSensor(172, "Prog1 charge", options=PROG_CHARGE_OPTIONS, bitmask=0x03),


Please remove these comments

kellerza · 2023-12-30T04:18:09Z

www/docs/guide/tested-inverters.md

@@ -9,6 +9,7 @@ There are several inverters that are rebranded Deye inverters, so you might have
 | Sunsynk 5.5kW  | Hubble AM-2       | beta/all | @kellerza     | BMS485 (top left)        |
 | Sunsynk 8.8kW  | BSL 8.2 kWH       | 0.0.8    | @dirkackerman | RS485 (1 in image below) |
 | Deye  8kW      | Pylontech US3000C | 0.1.3dev | @Kladrie      | RS485 (top left)         |
+| Deye 20kW 3PH HV | Deye BOS-G      | head |   | @rixxxx       | Solarman                 |


Is this an extra | after head?

kellerza · 2023-12-30T04:18:54Z

www/docs/reference/definitions.md

@@ -51,6 +51,17 @@ These definitions are used when you configure a three-phase inverter in the addo
 ```yaml
 SENSOR_DEFINITIONS: three-phase
 ```
+```


Extra three backticks?

Suggested change

```

kellerza · 2023-12-30T04:23:46Z

src/sunsynk/definitions3phhv.py

+    ),  # {2: "Inverter", 3: "Hybrid Inverter", 4: "Micro Inverter", 5: "3 Phase Hybrid Inverter" }),
+    FaultSensor((555, 556, 557, 558), "Fault"),
+    InverterStateSensor(500, "Overall state"),
+    SDStatusSensor(0, "SD Status", ""),  # type: ignore        # 3 Phase does not have SD Card but crashes when removed


Suggested change

SDStatusSensor(0, "SD Status", ""), # type: ignore # 3 Phase does not have SD Card but crashes when removed

SDStatusSensor(0, "SD Status", ""), # type: ignore

Not sure why this would crash? Seems like a leftover from the 3-ph

rixxxx · 2023-12-30T11:25:33Z

Thanks for the feedback. I'll incorporate the fixes.

RomcaKrestic · 2024-01-02T12:37:44Z

Hello, I am sending greetings from the Czech Republic.
I was interested in the integration of KellerZA into Home Assistant and I would like to ask if you have tried this integration on the SOFAR Solar 3-phase HV inverter.
Specifically, my friend and I have a Sofar HYD 10KTL-3PH on the wall, each one his own :-) and I am looking in vain for the possibility of connecting to Home Assistant with your integration.
Thanks for any tips on solutions.
Beautiful sunny day 😁
Roman

rixxxx · 2024-01-02T13:25:49Z

I'm not 100% sure since I dont have Sofar HYD 10KTL-3PH, but based on the pictures and some register information I found, it seems to be different from Sunsynk/Deye. It doesn't look too difficult to add another variant, but this pull request doesn't address that.

RomcaKrestic · 2024-01-02T13:37:22Z

I'm not 100% sure since I dont have Sofar HYD 10KTL-3PH, but based on the pictures and some register information I found, it seems to be different from Sunsynk/Deye. It doesn't look too difficult to add another variant, but this pull request doesn't address that.

it is definitely different from Dey, you can see it when sewing the SN inverter. There are some pictures instead of the serial number I entered...
Do you think you would like to deal with it? I would be happy to send you a LOG, or create access to Home Assistant :-)
Thanks for your interest and interesting work for the community

rixxxx · 2024-01-02T14:43:35Z

@kellerza all suggested fixed should be incorporated now. I'm not too familiar how the github ecosystem works and probably created unnecessary churn again, sorry for that.

RomcaKrestic · 2024-01-02T16:09:03Z

I probably won't be able to overcome that, I have no experience with reading data via MPTT and therefore I can't properly edit the definition file in src/sunsync/definitions3phhv.py. My limit is on the LOG file of the MPTT connection to the LSW-3 Logger. In the log, it can be seen that when querying the serial number, some nonsense value is returned and the communication is interrupted.. It looks like the inverter sent non-alphanumeric characters, but some nonsense characters, to the SN query via the Logger.
Would it be possible to somehow display what exactly comes from the inverter during communication, a complete communication LOG?
Thank you, Roman

kellerza · 2024-01-02T19:12:28Z

Thanks @rixxxx - this looks good

I’m not able to test it currently, but will merge - so please give some feedback

kellerza · 2024-01-02T19:14:50Z

@RomcaKrestic you can enable DEBUG to get extra logs

if you can find the registers you can use custome sensors - see mysensors in the docs to create these and test them

rixxxx · 2024-01-02T20:05:49Z

@RomcaKrestic there is nothing common with Deye/Sunsync 3ph hv inverter registers. This probably requires new definition file, doens't make sense to add conditions to each register. I think it would be best if you could file an issue with the problem. I may have a look.

rixxxx · 2024-01-02T20:06:54Z

@kellerza my existing config still works with the merged tree.

JanKraslice · 2024-03-12T13:30:13Z

Hello why even after your update the HV DEYE 30K still shows the battery voltage value for the LV ( low voltage) inverter

rixxxx · 2024-03-12T13:33:41Z

@JanKraslice it should be Battery 1 voltage in the latest code. There has been additional work on top of what I did.

JanKraslice · 2024-03-12T14:22:18Z

I think I have the latest version, please do I understand correctly that it updates automatically. I currently have Sunsynk/Deye Inverter Add-on (edge/dev) Current version: c5668d0 From: rivo nurges ***@***.***> Sent: Tuesday, March 12, 2024 2:34 PM To: kellerza/sunsynk ***@***.***> Cc: JanKraslice ***@***.***>; Mention ***@***.***> Subject: Re: [kellerza/sunsynk] 3 phase high voltage inverter support (PR #218) @JanKraslice <https://github.com/JanKraslice> it should be Battery 1 voltage in the latest release code. image.png (view on web) <https://github.com/kellerza/sunsynk/assets/12055276/67d59964-4419-4563-98d7-c42ca621ad61> — Reply to this email directly, view it on GitHub <#218 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDZ2UNTROOMXZKZ2QRAE3OLYX374ZAVCNFSM6AAAAABBGU7UWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRGY3DKMZQGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rixxxx · 2024-03-12T14:40:41Z

Ok, figured it out. LV definition has "Battery voltage", HV has "Battery 1 voltage. If you use battery_voltage in your configuration it will use the LV variant. I added both battery_1_voltage and battery_voltage and my sensors look like that:

I'm not using the HA addon and don't know how to do it but somewhere there should be a list of sensors where you need to change battery_voltage to battery_1_voltage.

rixxxx · 2024-03-12T14:42:34Z

@kellerza do we wan't to break LV backward compatibility and change the sensor name? Or add Battery voltage to HV to point to Battery 1?

JanKraslice · 2024-03-12T14:54:35Z

So in my case I don't know where to change, sorry I guess I need help. thanks (battery_1_voltage.)

JanKraslice · 2024-03-12T16:45:25Z

I've already figured it out and edited it, and you're right. battery_1_voltage is o.k. Can you advise how to add a sales disable. I am talking about the value: Solar Sell Max Sell Power In some part of Europe it is not worth selling electricity at certain times according to the exchange prices Thank you From: rivo nurges ***@***.***> Sent: Tuesday, March 12, 2024 3:41 PM To: kellerza/sunsynk ***@***.***> Cc: JanKraslice ***@***.***>; Mention ***@***.***> Subject: Re: [kellerza/sunsynk] 3 phase high voltage inverter support (PR #218) Ok, figured it out. LV definition has "Battery voltage", HV has "Battery 1 voltage. If you use battery_voltage in your configuration it will use the LV variant. I added both battery_1_voltage and battery_voltage and my sensors look like that: image.png (view on web) <https://github.com/kellerza/sunsynk/assets/12055276/2e6dfb93-2f8d-4a38-adaf-2cec5b5fcb8e> I'm not using the HA addon and don't know how to do it but somewhere there should be a list of sensors where you need to change battery_voltage to battery_1_voltage. — Reply to this email directly, view it on GitHub <#218 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDZ2UNT3DSV76AA2KXCKMXDYX4HYBAVCNFSM6AAAAABBGU7UWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJRHAYTANBRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rixxxx · 2024-03-12T20:43:40Z

Solar Sell should be "solar_export" and Max Sell Power should be "export_limit_power". You need to add them in the same way you did battery_1_voltage

JanKraslice · 2024-03-13T14:52:40Z

Still in the HV version the power sensor is missing the output of both load and backup inverter or one combining both. The ss_inverter_power is the total power of the inverter both output load to the object and output to the grid which is wrong if sold to the grid. From: rivo nurges ***@***.***> Sent: Tuesday, March 12, 2024 9:44 PM To: kellerza/sunsynk ***@***.***> Cc: JanKraslice ***@***.***>; Mention ***@***.***> Subject: Re: [kellerza/sunsynk] 3 phase high voltage inverter support (PR #218) Solar Sell should be "solar_export" and Max Sell Power should be "export_limit_power". You need to add them in the same way you did battery_1_voltage — Reply to this email directly, view it on GitHub <#218 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDZ2UNRAQDKGXNLSOLTR2N3YX5SJFAVCNFSM6AAAAABBGU7UWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGU2DGNZRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

JanKraslice · 2024-03-13T14:59:54Z

Supplementary essential_power and non_essential_power 15:59:40 INFO Using three-phase HV sensor definitions. 15:59:40 ERROR Unknown sensor entered: aux_power 15:59:40 ERROR Unknown sensor entered: essential_power 15:59:40 ERROR Unknown sensor: grid_voltage 15:59:40 ERROR Neznámné zadané pivot: inverter_current 15:59:40 ERROR Unknown sensor: load_frequency 15:59:40 ERROR non_newsreader: non_essential_power From: rivo nurges ***@***.***> Sent: Tuesday, March 12, 2024 9:44 PM To: kellerza/sunsynk ***@***.***> Cc: JanKraslice ***@***.***>; Mention ***@***.***> Subject: Re: [kellerza/sunsynk] 3 phase high voltage inverter support (PR #218) Solar Sell should be "solar_export" and Max Sell Power should be "export_limit_power". You need to add them in the same way you did battery_1_voltage — Reply to this email directly, view it on GitHub <#218 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDZ2UNRAQDKGXNLSOLTR2N3YX5SJFAVCNFSM6AAAAABBGU7UWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJSGU2DGNZRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rixxxx mentioned this pull request Dec 29, 2023

SUN-29.9/30/35/40/50K-SG01HP3-EU #208

Closed

kellerza reviewed Dec 30, 2023

View reviewed changes

rixxxx closed this Jan 2, 2024

add Sunsynk/Deye 3phase HV inverter support

917f718

rixxxx reopened this Jan 2, 2024

Merge branch 'kellerza:main' into main

9da7b0e

kellerza merged commit 605e0f4 into kellerza:main Jan 2, 2024
8 checks passed

rixxxx mentioned this pull request Feb 12, 2024

sync 3PH LV and HV definitions #235

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3 phase high voltage inverter support #218

3 phase high voltage inverter support #218

rixxxx commented Dec 29, 2023

codecov bot commented Dec 29, 2023 •

edited

Loading

rixxxx commented Dec 29, 2023

kellerza left a comment

kellerza Dec 30, 2023

kellerza Dec 30, 2023

kellerza Dec 30, 2023

kellerza Dec 30, 2023

kellerza Dec 30, 2023

kellerza Dec 30, 2023

rixxxx commented Dec 30, 2023

RomcaKrestic commented Jan 2, 2024

rixxxx commented Jan 2, 2024

RomcaKrestic commented Jan 2, 2024

rixxxx commented Jan 2, 2024

RomcaKrestic commented Jan 2, 2024

kellerza commented Jan 2, 2024

kellerza commented Jan 2, 2024

rixxxx commented Jan 2, 2024

rixxxx commented Jan 2, 2024

JanKraslice commented Mar 12, 2024

rixxxx commented Mar 12, 2024 •

edited

Loading

JanKraslice commented Mar 12, 2024 via email

rixxxx commented Mar 12, 2024

rixxxx commented Mar 12, 2024 •

edited

Loading

JanKraslice commented Mar 12, 2024

JanKraslice commented Mar 12, 2024 via email

rixxxx commented Mar 12, 2024

JanKraslice commented Mar 13, 2024 via email

JanKraslice commented Mar 13, 2024 via email

	SDStatusSensor(0, "SD Status", ""), # type: ignore # 3 Phase does not have SD Card but crashes when removed
	SDStatusSensor(0, "SD Status", ""), # type: ignore

3 phase high voltage inverter support #218

3 phase high voltage inverter support #218

Conversation

rixxxx commented Dec 29, 2023

codecov bot commented Dec 29, 2023 • edited Loading

Codecov Report

rixxxx commented Dec 29, 2023

kellerza left a comment

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

kellerza Dec 30, 2023

Choose a reason for hiding this comment

rixxxx commented Dec 30, 2023

RomcaKrestic commented Jan 2, 2024

rixxxx commented Jan 2, 2024

RomcaKrestic commented Jan 2, 2024

rixxxx commented Jan 2, 2024

RomcaKrestic commented Jan 2, 2024

kellerza commented Jan 2, 2024

kellerza commented Jan 2, 2024

rixxxx commented Jan 2, 2024

rixxxx commented Jan 2, 2024

JanKraslice commented Mar 12, 2024

rixxxx commented Mar 12, 2024 • edited Loading

JanKraslice commented Mar 12, 2024 via email

rixxxx commented Mar 12, 2024

rixxxx commented Mar 12, 2024 • edited Loading

JanKraslice commented Mar 12, 2024

JanKraslice commented Mar 12, 2024 via email

rixxxx commented Mar 12, 2024

JanKraslice commented Mar 13, 2024 via email

JanKraslice commented Mar 13, 2024 via email

codecov bot commented Dec 29, 2023 •

edited

Loading

rixxxx commented Mar 12, 2024 •

edited

Loading

rixxxx commented Mar 12, 2024 •

edited

Loading