Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly fallback to HTTP api #27

Merged
merged 5 commits into from
Oct 15, 2019
Merged

Correctly fallback to HTTP api #27

merged 5 commits into from
Oct 15, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 13, 2019 •
edited
Loading

Closes #28 .

@tesuji tesuji mentioned this pull request Oct 13, 2019
Closed
@tesuji

This comment has been minimized.

Sign in to view
@tesuji tesuji changed the title CI: Add windows and osx Add default user-agent when query GitHub API Oct 13, 2019
@tesuji

This comment has been minimized.

Sign in to view
@tesuji
Copy link
Contributor Author

tesuji commented Oct 13, 2019

CI is passed. Ping @kennytm .

@tesuji tesuji changed the title Add default user-agent when query GitHub API Correctly fallback to HTTP api Oct 14, 2019
tesuji
tesuji commented Oct 14, 2019
View reviewed changes
@tesuji tesuji force-pushed the ci-more-oses branch 2 times, most recently from e93759e to abfeaf8 Compare October 14, 2019 07:31
kennytm
kennytm reviewed Oct 14, 2019
View reviewed changes
Copy link
Owner

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@phansch phansch mentioned this pull request Oct 14, 2019
Closed
@tesuji tesuji requested a review from kennytm October 15, 2019 08:09
@kennytm kennytm merged commit da12bd2 into kennytm:master Oct 15, 2019
@tesuji tesuji deleted the ci-more-oses branch October 15, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get 403 error when query GitHub HTTP API on macOS
2 participants
@tesuji @kennytm