Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Fix failing React Tests #62

Merged
merged 3 commits into from
Jul 16, 2016
Merged

Fix failing React Tests #62

merged 3 commits into from
Jul 16, 2016

Conversation

kevgathuku
Copy link
Owner

@kevgathuku kevgathuku commented Jul 16, 2016

This should prevent React from throwing an error in cases where the React production build is used in testing
Ref: facebook/react#7231

@kevgathuku kevgathuku changed the title Explicitly set NODE_ENV to test for frontend tests Explicitly set NODE_ENV for frontend tests Jul 16, 2016
@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling def7e9c on chore/fix-failing-fe-tests into 6eca86a on develop.

@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 54a1ea8 on chore/fix-failing-fe-tests into 6eca86a on develop.

@codecov-io
Copy link

codecov-io commented Jul 16, 2016

Current coverage is 87.64%

No coverage report found for develop at 6eca86a.

Powered by Codecov. Last updated by 6eca86a...08a572a

@kevgathuku kevgathuku changed the title Explicitly set NODE_ENV for frontend tests Fix failing React Tests Jul 16, 2016
This is to avoid a regression in v15.2.1 where an error is being
thrown in cases where the production build is used during testing
Ref: facebook/react#7231
@kevgathuku kevgathuku force-pushed the chore/fix-failing-fe-tests branch from 54a1ea8 to 08a572a Compare July 16, 2016 20:49
@coveralls
Copy link

coveralls commented Jul 16, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 08a572a on chore/fix-failing-fe-tests into 6eca86a on develop.

@kevgathuku kevgathuku merged commit 73c9a07 into develop Jul 16, 2016
@kevgathuku kevgathuku deleted the chore/fix-failing-fe-tests branch July 16, 2016 20:52
kevgathuku added a commit that referenced this pull request Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants