Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuration of display_name for oidc identity providers #1033

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

bnjns
Copy link
Contributor

@bnjns bnjns commented Dec 16, 2024

I'm glad I've found something that allows me to contribute to this provider, as it's something I've been using for a really long time.

Came across this issue earlier today - this change allows users to configure the display name of OIDC and Google OIDC identity providers.

Resolves #639

@bnjns bnjns force-pushed the feat/idp-missing-attributes branch from 19bf58c to 212d122 Compare December 16, 2024 22:38
@sschu
Copy link
Contributor

sschu commented Jan 14, 2025

@bnjns Thanks for the contribution! Do you consider this ready for review?

@bnjns
Copy link
Contributor Author

bnjns commented Jan 14, 2025

@bnjns Thanks for the contribution! Do you consider this ready for review?

@sschu Apologies, I completely forgot about this 🤦 I wasn't sure exactly how much testing is necessary, but I think this is probably ready yeah

@bnjns bnjns marked this pull request as ready for review January 14, 2025 11:28
Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasdarimont thomasdarimont force-pushed the feat/idp-missing-attributes branch from 212d122 to 24085ec Compare January 23, 2025 10:21
@sschu sschu enabled auto-merge (squash) January 23, 2025 15:28
@sschu sschu merged commit 4d7f55a into keycloak:main Jan 23, 2025
4 checks passed
angeloxx pushed a commit to angeloxx/terraform-provider-keycloak that referenced this pull request Jan 26, 2025
chrismilson pushed a commit to chrismilson/terraform-provider-keycloak that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should be able to set a displayName on the keycloak_oidc_google_identity_provider as well
3 participants