Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1073 add organization setting to realm #1076

Merged
merged 4 commits into from
Jan 23, 2025
Merged

1073 add organization setting to realm #1076

merged 4 commits into from
Jan 23, 2025

Conversation

sschu
Copy link
Contributor

@sschu sschu commented Jan 15, 2025

Closes #1073

@sschu
1073 add organization setting to realm
722c31d 
Signed-off-by: Sebastian Schuster <[email protected]>
thomasdarimont
thomasdarimont requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@thomasdarimont thomasdarimont left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I'd instead use organizations_enabled rather than just organizations. This explains the intent more clearly.

We also should exclude the attribute in tests <= KC24 .

sschu and others added 2 commits January 22, 2025 10:46
@sschu @thomasdarimont
Apply suggestions from code review
406d273 
Co-authored-by: Thomas Darimont <[email protected]>
Signed-off-by: Sebastian Schuster <[email protected]>
@sschu
Format fix
d81d192 
Signed-off-by: Sebastian Schuster <[email protected]>
@sschu sschu enabled auto-merge (squash) January 23, 2025 07:03
thomasdarimont
thomasdarimont approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sschu sschu merged commit 5fcefb5 into keycloak:main Jan 23, 2025
4 checks passed
angeloxx pushed a commit to angeloxx/terraform-provider-keycloak that referenced this pull request Jan 26, 2025
@sschu @thomasdarimont @angeloxx
1073 add organization setting to realm (keycloak#1076)
f8508b6 
* 1073 add organization setting to realm

Signed-off-by: Sebastian Schuster <[email protected]>

* Apply suggestions from code review

Co-authored-by: Thomas Darimont <[email protected]>
Signed-off-by: Sebastian Schuster <[email protected]>

* Format fix

Signed-off-by: Sebastian Schuster <[email protected]>

---------

Signed-off-by: Sebastian Schuster <[email protected]>
Signed-off-by: Sebastian Schuster <[email protected]>
Co-authored-by: Thomas Darimont <[email protected]>
Signed-off-by: angeloxx <[email protected]>
chrismilson pushed a commit to chrismilson/terraform-provider-keycloak that referenced this pull request Feb 26, 2025
@sschu @thomasdarimont
1073 add organization setting to realm (keycloak#1076)
f7ecd98 
* 1073 add organization setting to realm

Signed-off-by: Sebastian Schuster <[email protected]>

* Apply suggestions from code review

Co-authored-by: Thomas Darimont <[email protected]>
Signed-off-by: Sebastian Schuster <[email protected]>

* Format fix

Signed-off-by: Sebastian Schuster <[email protected]>

---------

Signed-off-by: Sebastian Schuster <[email protected]>
Signed-off-by: Sebastian Schuster <[email protected]>
Co-authored-by: Thomas Darimont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasdarimont thomasdarimont thomasdarimont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot enable keycloak organizations on an existing realm
2 participants
@sschu @thomasdarimont