Port access control tests to new interfaces #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/CW17RVDGsxtiy1ZaSWD2rcGMupjZ |
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
6e610be to
b7fb110
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
fa65eb8 to
409ced2
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
409ced2 to
53a8eb8
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
53a8eb8 to
ea9aa9e
Compare
🦋 Changeset detectedLatest commit: 499f089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
ea9aa9e to
bb3ce3f
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
bb3ce3f to
072a7fc
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
072a7fc to
b00fdee
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
b00fdee to
42379cd
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
42379cd to
c81c0ef
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
c83ef37 to
f6ffabf
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
f6ffabf to
4eb616d
Compare
timleslie
changed the title
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
4eb616d to
e20f6bb
Compare
emmatown
requested changes
Mar 12, 2021
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
63e67b3 to
12f7c72
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
aca1c7b to
9aac937
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
5539a08 to
cb382fa
Compare
timleslie
force-pushed
the
udpate-access-control-tests
branch
from
cb382fa to
499f089
Compare
emmatown
approved these changes
Mar 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to test the access control API of the new interfaces. This PR ports the existing tests to use the new interfaces.
This has exposed various internal fixes which need to happen before these tests will pass. I will ship separate PRs for each of these changes, and then put this PR up for review once they are complete.