Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace keystone-next prototype with keystone-next dev and a config option to determine if migrations should be used or not #5163

Merged
merged 9 commits into from
Mar 21, 2021

Conversation

emmatown
Copy link
Member

Currently, it's not very clear what people should use and what keystone-next prototype is and isn't compatible with, this PR makes it clear what command you should run and what commands you can't use if you're not using migrations. For example, we had an example that had dev and prototype scripts which doesn't make sense since they're mutually exclusive workflows. This replaces keystone-next prototype with a db.useMigrations option to determine if Keystone should use migrations or push the schema with the potential for data loss.

…ption to determine if migrations should be used or not
@vercel
Copy link

vercel bot commented Mar 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/GepS4s4icPr4AyFDLFJ52mEuSmKr
✅ Preview: https://keystone-next-git-replace-prototype-command-with-a-conf-49bb08.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2021

🦋 Changeset detected

Latest commit: 2726276

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@keystone-next/keystone Major
@keystone-next/types Major
@keystone-next/test-utils-legacy Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-todo Patch
@keystone-next/admin-ui Patch
@keystone-next/auth Major
@keystone-next/api-tests-legacy Patch
@keystone-next/admin-ui-utils Patch
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2726276:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview March 19, 2021 01:46 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2021 02:09 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2021 02:13 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2021 02:28 Inactive
@vercel vercel bot temporarily deployed to Preview March 19, 2021 03:31 Inactive
@emmatown emmatown requested a review from timleslie March 19, 2021 03:41
@vercel vercel bot temporarily deployed to Preview March 19, 2021 03:41 Inactive
@vercel vercel bot temporarily deployed to Preview March 21, 2021 21:39 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@vercel vercel bot temporarily deployed to Preview March 21, 2021 22:08 Inactive
@emmatown emmatown enabled auto-merge (squash) March 21, 2021 22:08
@emmatown emmatown merged commit b37cbff into master Mar 21, 2021
@emmatown emmatown deleted the replace-prototype-command-with-a-config-option branch March 21, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants