Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling (verbose mode?) #159

Open
1 of 3 tasks
bjgill opened this issue Aug 6, 2017 · 1 comment
Open
1 of 3 tasks

Improve error handling (verbose mode?) #159

bjgill opened this issue Aug 6, 2017 · 1 comment
Labels
enhancement

Comments

@bjgill
Copy link
Collaborator

bjgill commented Aug 6, 2017 •
edited
Loading

See #153 (review)

It would be nice to:

  • Switch to a more modern means of handling errors - error-chain instead of quick_error and Box<Error>
  • Introduce some logging (toggled by a verbose mode, perhaps?)
  • Have a good test suite for the CLI behaviour

waltz_cli seems like a good example of the quality bar we should be aiming for.
@bjgill
Copy link
Collaborator Author

bjgill commented Aug 31, 2017

As an added bonus, switching to error-chain will ensure that all our errors implement Send, which will make parallelisation (#158) quite a bit easier.

@bjgill bjgill mentioned this issue Sep 1, 2017
Merged
bors bot added a commit that referenced this issue Sep 3, 2017
@bors
Merge #167
f40507d 
167: Switch to use error-chain r=bjgill a=bjgill

I've kept the quick-error style errors where they're used multiple times, and otherwise converted to string errors - our errors are for diagnostics only (not for anyone to try and do anything with).

This is the first step to solving #159.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjgill