-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade workspace's crate version #426
Comments
Let me see if I understand the steps
Not a maintainer but I think thats understandable. Even better will be with my next steps after #482 where |
I'm a little uncertain about the proposed fix. I think it will leading to surprising behavior if make Instead, I would expect the sync lock file and upgrade functions to check that its a path dependency and generate the appropriate |
With path and git dependencies, you can specify a version for use with the registry. If its incompatible, I believe the resolver will fail, so we don't need to handle that case. That just leaves `--to-lockfile`. This just means post-poning the check for the registry to be in the non-lockfile case. Fixes killercup#426
Hello,
I have a workspace where I have multiple crates: crate_a, crate_b, crate_c.
I have to put both version and path for the crates from my workspace into the Cargo.toml (to allow crates to be published at crates.io):
Unfortunately cargo upgrade doesn't work in that case.
I'm able to fix that maxv-rust@8b4bfa3 but I'm not sure if you're interested in that kind of changes.
Please let me know what is the best way to fix the issue:
Have a great day,
MaxV
The text was updated successfully, but these errors were encountered: