Skip to content

Commit

Permalink
Add option to remove iframe from tabindex
Browse files Browse the repository at this point in the history
  • Loading branch information
Timo Kirkkala committed Nov 19, 2020
1 parent be94112 commit 25f0049
Show file tree
Hide file tree
Showing 72 changed files with 158 additions and 74 deletions.
20 changes: 17 additions & 3 deletions plugins/iframe/dialogs/iframe.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
// http://www.w3.org/TR/REC-html40/present/frames.html#h-16.5
var checkboxValues = {
scrolling: { 'true': 'yes', 'false': 'no' },
frameborder: { 'true': '1', 'false': '0' }
frameborder: { 'true': '1', 'false': '0' },
tabindex: { 'true': '-1', 'false': false }
};

function loadValue( iframeNode ) {
Expand All @@ -28,8 +29,13 @@
value = this.getValue();
if ( isRemove )
iframeNode.removeAttribute( this.att || this.id );
else if ( isCheckbox )
iframeNode.setAttribute( this.id, checkboxValues[ this.id ][ value ] );
else if ( isCheckbox ) {
if ( value === false ) {
iframeNode.removeAttribute( this.id );
} else {
iframeNode.setAttribute( this.id, checkboxValues[this.id][value] );
}
}
else
iframeNode.setAttribute( this.att || this.id, value );
}
Expand Down Expand Up @@ -181,6 +187,14 @@
commit: commitValue
} ]
},
{
id: 'tabindex',
type: 'checkbox',
requiredContent: 'iframe[tabindex]',
label: iframeLang.tabindex,
setup: loadValue,
commit: commitValue
},
{
type: 'hbox',
widths: [ '50%', '50%' ],
Expand Down
3 changes: 2 additions & 1 deletion plugins/iframe/lang/af.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'af', {
noUrl: 'Gee die iframe URL',
scrolling: 'Skuifbalke aan',
title: 'IFrame Eienskappe',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ar.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ar', {
noUrl: 'فضلا أكتب رابط الـ iframe',
scrolling: 'تفعيل أشرطة الإنتقال',
title: 'خصائص iframe',
toolbar: 'iframe'
toolbar: 'iframe',
tabindex: 'Remove from tabindex', // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/az.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'az', {
noUrl: 'Çərçivənin ünvanı daxil edin',
scrolling: 'Şürüşdürmələri əlavə et',
title: 'İFRAME elementinin alətləri',
toolbar: 'İFRAME'
toolbar: 'İFRAME',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/bg.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'bg', {
noUrl: 'Моля въведете URL за iFrame',
scrolling: 'Активира прелистване',
title: 'IFrame настройки',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/bn.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'bn', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/bs.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'bs', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ca.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ca', {
noUrl: 'Si us plau, introdueixi la URL de l\'iframe',
scrolling: 'Activa les barres de desplaçament',
title: 'Propietats de l\'IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/cs.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'cs', {
noUrl: 'Zadejte prosím URL obsahu pro IFrame',
scrolling: 'Zapnout posuvníky',
title: 'Vlastnosti IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'cy', {
noUrl: 'Rhowch URL yr iframe',
scrolling: 'Galluogi bariau sgrolio',
title: 'Priodweddau IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/da.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'da', {
noUrl: 'Venligst indsæt URL på iframen',
scrolling: 'Aktiver scrollbars',
title: 'Iframe egenskaber',
toolbar: 'Iframe'
toolbar: 'Iframe',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/de-ch.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'de-ch', {
noUrl: 'Bitte geben Sie die IFrame-URL an',
scrolling: 'Rollbalken anzeigen',
title: 'IFrame-Eigenschaften',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/de.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'de', {
noUrl: 'Bitte geben Sie die IFrame-URL an',
scrolling: 'Rollbalken anzeigen',
title: 'IFrame-Eigenschaften',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/el.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'el', {
noUrl: 'Παρακαλούμε εισάγεται το URL του iframe',
scrolling: 'Ενεργοποίηση μπαρών κύλισης',
title: 'Ιδιότητες IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/en-au.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'en-au', {
noUrl: 'Please type the iframe URL',
scrolling: 'Enable scrollbars',
title: 'IFrame Properties',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex'
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/en-ca.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'en-ca', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/en-gb.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'en-gb', {
noUrl: 'Please type the iframe URL',
scrolling: 'Enable scrollbars',
title: 'IFrame Properties',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex'
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/en.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'en', {
noUrl: 'Please type the iframe URL',
scrolling: 'Enable scrollbars',
title: 'IFrame Properties',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex'
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/eo.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'eo', {
noUrl: 'Bonvolu entajpi la retadreson de la ligilo al la enlinia kadro (IFrame)',
scrolling: 'Ebligi rulumskalon',
title: 'Atributoj de la enlinia kadro (IFrame)',
toolbar: 'Enlinia kadro (IFrame)'
toolbar: 'Enlinia kadro (IFrame)',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/es-mx.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'es-mx', {
noUrl: 'Ingresa la URL del iframe',
scrolling: 'Habilitar la barra de desplazamiento',
title: 'Propiedades del IFrame',
toolbar: 'Iframe'
toolbar: 'Iframe',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/es.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'es', {
noUrl: 'Por favor, escriba la dirección del iframe',
scrolling: 'Activar barras de desplazamiento',
title: 'Propiedades de iframe',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/et.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'et', {
noUrl: 'Vali iframe URLi liik',
scrolling: 'Kerimisribade lubamine',
title: 'IFrame omadused',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/eu.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'eu', {
noUrl: 'Idatzi iframe-aren URLa, mesedez.',
scrolling: 'Gaitu korritze-barrak',
title: 'IFrame-aren propietateak',
toolbar: 'IFrame-a'
toolbar: 'IFrame-a',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/fa.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'fa', {
noUrl: 'لطفا مسیر URL iframe را درج کنید',
scrolling: 'نمایش خطکشها',
title: 'ویژگیهای IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/fi.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'fi', {
noUrl: 'Anna IFrame-kehykselle lähdeosoite (src)',
scrolling: 'Näytä vierityspalkit',
title: 'IFrame-kehyksen ominaisuudet',
toolbar: 'IFrame-kehys'
toolbar: 'IFrame-kehys',
tabindex: 'Poista kehys tabindexistä'
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/fo.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'fo', {
noUrl: 'Vinarliga skriva URL til iframe',
scrolling: 'Loyv scrollbars',
title: 'Møguleikar fyri IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/fr-ca.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'fr-ca', {
noUrl: 'Veuillez entre l\'URL du IFrame',
scrolling: 'Activer les barres de défilement',
title: 'Propriétés du IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/fr.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'fr', {
noUrl: 'Veuillez entrer l\'URL du contenu du cadre',
scrolling: 'Activer les barres de défilement',
title: 'Propriétés du cadre de contenu incorporé',
toolbar: 'Cadre de contenu incorporé'
toolbar: 'Cadre de contenu incorporé',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/gl.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'gl', {
noUrl: 'Escriba o enderezo do iframe',
scrolling: 'Activar as barras de desprazamento',
title: 'Propiedades do iFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/gu.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'gu', {
noUrl: 'iframe URL ટાઈપ્ કરો',
scrolling: 'સ્ક્રોલબાર ચાલુ કરવા',
title: 'IFrame વિકલ્પો',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/he.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'he', {
noUrl: 'יש להכניס כתובת לחלון.',
scrolling: 'אפשר פסי גלילה',
title: 'מאפייני חלון פנימי (iframe)',
toolbar: 'חלון פנימי (iframe)'
toolbar: 'חלון פנימי (iframe)',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/hi.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'hi', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/hr.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'hr', {
noUrl: 'Unesite URL IFrame-a',
scrolling: 'Omogući trake za skrolanje',
title: 'IFrame svojstva',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/hu.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'hu', {
noUrl: 'Kérem írja be a iframe URL-t',
scrolling: 'Gördítősáv bekapcsolása',
title: 'IFrame Tulajdonságok',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/id.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'id', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Aktifkan Scrollbar',
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/is.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'is', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/it.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'it', {
noUrl: 'Inserire l\'URL del campo IFrame',
scrolling: 'Abilita scrollbar',
title: 'Proprietà IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ja.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ja', {
noUrl: 'iframeのURLを入力してください。',
scrolling: 'スクロールバーの表示を許可',
title: 'iFrameのプロパティ',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ka.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ka', {
noUrl: 'აკრიფეთ iframe-ის URL',
scrolling: 'გადახვევის ზოლების დაშვება',
title: 'IFrame-ის პარამეტრები',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/km.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'km', {
noUrl: 'សូម​បញ្ចូល URL របស់ iframe',
scrolling: 'ប្រើ​របារ​រំកិល',
title: 'លក្ខណៈ​សម្បត្តិ IFrame',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ko.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ko', {
noUrl: '아이프레임 주소(URL)를 입력해주세요.',
scrolling: '스크롤바 사용',
title: '아이프레임 속성',
toolbar: '아이프레임'
toolbar: '아이프레임',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/ku.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'ku', {
noUrl: 'تکایه ناونیشانی بەستەر بنووسه بۆ چووارچێوه',
scrolling: 'چالاککردنی هاتووچۆپێکردن',
title: 'دیالۆگی چووارچێوه',
toolbar: 'چووارچێوه'
toolbar: 'چووارچێوه',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/lt.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'lt', {
noUrl: 'Nurodykite iframe nuorodą',
scrolling: 'Įjungti slankiklius',
title: 'IFrame nustatymai',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/lv.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'lv', {
noUrl: 'Norādiet iframe adresi',
scrolling: 'Atļaut ritjoslas',
title: 'IFrame uzstādījumi',
toolbar: 'IFrame'
toolbar: 'IFrame',
tabindex: 'Remove from tabindex' // MISSING
} );
3 changes: 2 additions & 1 deletion plugins/iframe/lang/mk.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ CKEDITOR.plugins.setLang( 'iframe', 'mk', {
noUrl: 'Please type the iframe URL', // MISSING
scrolling: 'Enable scrollbars', // MISSING
title: 'IFrame Properties', // MISSING
toolbar: 'IFrame' // MISSING
toolbar: 'IFrame', // MISSING
tabindex: 'Remove from tabindex' // MISSING
} );
Loading

0 comments on commit 25f0049

Please sign in to comment.