Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PATCH-Verb #133

Closed
rrrnld opened this issue Mar 1, 2017 · 5 comments · Fixed by #156
Closed

Missing PATCH-Verb #133

rrrnld opened this issue Mar 1, 2017 · 5 comments · Fixed by #156

Comments

@rrrnld
Copy link

rrrnld commented Mar 1, 2017

Is there a possibility to issue PATCH-requests without using the semi-standard X-HTTP-Method-Override header, e.g. Fuel.patch(...)?

Maybe I'm just not seeing it, there is a patch method defined here but it's not exposed like GET, POST, PUT or DELETE. Is there a reason for this?

@andreparodi
Copy link

I was looking for this as well. Although the enum is defined it looks like the appropriate methods in the Fuel class are not defined to do the patch request. see here

it looks like it should be pretty easy to add.

how did you do the request with the X-HTTP-Method-Override?

@kittinunf
Copy link
Owner

Yes ... you are right. I think Fuel should expose that as Fuel.patch then cover the X-HTTP-Method-Override behind the scene. I will include this into the next release.

@kittinunf
Copy link
Owner

I will cover this issue by #156

@henryfjordan
Copy link

This was such a dark pattern. It led to me spending a few hours banging my head against a mystery 405 response code until I logged into our API gateway and started tracing requests.

💩

@SleeplessByte
Copy link
Collaborator

Is it currently not correctly documented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants