Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PATCH method for Fuel #156

Merged
merged 3 commits into from
May 6, 2017
Merged

Add PATCH method for Fuel #156

merged 3 commits into from
May 6, 2017

Conversation

kittinunf
Copy link
Owner

@kittinunf kittinunf commented May 5, 2017

What's in this PR?

This PR mitigates the issue where Fuel don't expose PATCH method for client to use. This PR will remedy that.

Merging this should close #133

@kittinunf kittinunf mentioned this pull request May 5, 2017
@kittinunf kittinunf force-pushed the kv/add-patch-method branch from 020cb82 to 90ade9d Compare May 5, 2017 05:49
@babedev
Copy link
Collaborator

babedev commented May 5, 2017

Something wrong with tests?

@kittinunf kittinunf self-assigned this May 5, 2017
@kittinunf
Copy link
Owner Author

kittinunf commented May 6, 2017

It seems like httpbin.org doesn't support POST method for www.httpbin.org/patch endpoint. 😿

@codecov
Copy link

codecov bot commented May 6, 2017

Codecov Report

Merging #156 into master will increase coverage by 1.13%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     60.72%   61.85%   +1.13%     
- Complexity      145      161      +16     
============================================
  Files            29       29              
  Lines           802      852      +50     
  Branches        143      158      +15     
============================================
+ Hits            487      527      +40     
- Misses          229      232       +3     
- Partials         86       93       +7
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/com/github/kittinunf/fuel/core/Request.kt 63.15% <ø> (+0.78%) 51 <0> (+9) ⬆️
.../src/main/kotlin/com/github/kittinunf/fuel/Fuel.kt 85.36% <100%> (+1.58%) 1 <0> (ø) ⬇️
...in/com/github/kittinunf/fuel/toolbox/HttpClient.kt 72.41% <100%> (+0.48%) 17 <0> (+2) ⬆️
.../kittinunf/fuel/core/requests/UploadTaskRequest.kt 79.59% <0%> (+7.36%) 12% <0%> (+5%) ⬆️
...kotlin/com/github/kittinunf/fuel/util/Delegates.kt 83.33% <0%> (+16.66%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a4dde...6b34f74. Read the comment docs.

@kittinunf
Copy link
Owner Author

🎉 🎉 🎉

@babedev
Copy link
Collaborator

babedev commented May 6, 2017

Wow, let's merge this.

@kittinunf kittinunf merged commit ee3d422 into master May 6, 2017
@kittinunf kittinunf deleted the kv/add-patch-method branch May 6, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing PATCH-Verb
2 participants