Multiple files upload #157
Conversation
babedev
added
the
🦄 enhancement
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
============================================
+ Coverage 60.72% 61.31% +0.58%
- Complexity 145 147 +2
============================================
Files 29 29
Lines 802 809 +7
Branches 143 143
============================================
+ Hits 487 496 +9
+ Misses 229 228 -1
+ Partials 86 85 -1
Continue to review full report at Codecov.
|
| @@ -140,6 +140,15 @@ class Request : Fuel.RequestConvertible { | |||
| return this | |||
| } | |||
|
|
|||
| fun source(source: (Request, URL) -> File): Request { | |||
There was a problem hiding this comment.
Can we implement source call sources internally so we can save some duplications?
There was a problem hiding this comment.
Fixed. source call sources and add single file into List.
| @@ -131,7 +131,7 @@ class Request : Fuel.RequestConvertible { | |||
| return this | |||
| } | |||
|
|
|||
| fun source(source: (Request, URL) -> File): Request { | |||
| fun sources(source: (Request, URL) -> Array<File>): Request { | |||
There was a problem hiding this comment.
What do you think about return this as Iterable<File>? This might make our API more flexible.
| write("--$boundary" + CRLF) | ||
| write("Content-Disposition: form-data; name=\"" + it.first + "\"" + CRLF) | ||
| write("Content-Type: text/plain" + CRLF) | ||
| write("--$boundary$CRLF") |
| } | ||
| files.forEachIndexed { i, file -> | ||
| val postFix = if (files.size == 1) "" else "${i + 1}" | ||
| fileInputStream = FileInputStream(file) |
There was a problem hiding this comment.
You might consider move this to L43 so it gets closer to the place that we actually use.
Also as a protip, Kotlin use function is very handy to work with anything implements closeable interface.
FileInputStream(f).use {
//do something with inputstream
}
//automatically close the stream for usThere was a problem hiding this comment.
wow, that's cool. I will try it.
|
I have left some comments. Thanks so much for helping us implementing this feature 👏 |
| @@ -131,7 +131,7 @@ class Request : Fuel.RequestConvertible { | |||
| return this | |||
| } | |||
|
|
|||
| fun source(source: (Request, URL) -> File): Request { | |||
| fun sources(source: (Request, URL) -> Collection<File>): Request { | |||
There was a problem hiding this comment.
Oh, you review so fast. I will change it :).
|
|
||
| write(CRLF) | ||
| write("--$boundary$CRLF") | ||
| write("Content-Disposition: form-data; name=\"" + request.name + "$postFix\"; filename=\"${file.name}\"") |
There was a problem hiding this comment.
Should we also make this as String interpolation?
|
This is awesome! Welcome @babedev for your first PR 💯 . 🚢 🇮🇹 from me. |
What's in this PR?
Implementation of multiple files upload as mentioned in #147 . I created new method call
sourcesso we can pass multiple files intosourceCallback.Example
sources { request, url -> arrayOf( File(currentDir, "lorem_ipsum_short.tmp"), File(currentDir, "lorem_ipsum_long.tmp") ) }