RFC: Use Redis as celery broker in dev environment #213
Conversation
brianhelba
force-pushed
the
redis-celery-broker
branch
from
eae6d55 to
646a4e6
Compare
|
I've just rebased this and included the changes from kitware-resonant/django-composed-configuration#213 too. This can now be handled in this single PR. |
| CELERY_BROKER_POOL_LIMIT = 1 | ||
| CELERY_BROKER_HEARTBEAT = None | ||
| CELERY_BROKER_CONNECTION_TIMEOUT = 30 |
There was a problem hiding this comment.
Are all of these values still the appropriate defaults?
If they need to be set per-deployment, these should be moved out of the resonant_settings shared package and into the cookiecutter files.
There was a problem hiding this comment.
I went back and forth on this -- on the one hand, yes, this is deployment-specific. On the other hand, quite a few of these settings within django-resonant-settings are also just sensible defaults and overriding them is common for specific applications and deployments. I don't have a strong opinion on whether we should hide this for cookiecutter ejections or not, so let me know which you prefer.
There was a problem hiding this comment.
To be concrete here, note that CELERY_WORKER_CONCURRENCY is also here in this package rather than in the cookiecutter, and that's extremely application- and deployment-specific.
This change is sufficient to switch celery to Redis in development.
For our standard deployment, using Redis will depend on kitware-resonant/django-composed-configuration#213 and a not yet complete PR to our terraform module that I'll link to this later.