Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare development tools in dependency groups #288

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

brianhelba
Copy link
Contributor

This is recommended by Tox, will make it easier to install tooling into development environments, and perfectly fits the use case outlined by PEP 735.

This is recommended by Tox, will make it easier to install tooling into
development environments, and perfectly fits the use case outlined by PEP 735.
@brianhelba brianhelba requested a review from danlamanna January 29, 2025 18:22
@brianhelba
Copy link
Contributor Author

I'm leaving actual runtime requirements for development in the dev extra, instead of putting them in a dependency group, since all the other runtime requirements are already in dependencies.

PEP 735 actually outlines a use case for web applications where a project isn't defined at all, and all requirements are defined in a dependency group (with an arbitrary name like main) instead of project.dependencies. That might be a reasonable move, so we can skip the packaging step entirely, but pip currently doesn't support dependency groups (and they're moving slowly at implementation), so we'll need to wait (or switch entirely to uv).

@@ -1,6 +1,5 @@
[tox]
# Don't use "min_version", to ensure Tox 3 respects this
minversion = 4
min_version = 4.22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is the earliest version that supports dependency_groups?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus, Tox 4.0 was released in December 2022, so I'm fine to assume nobody is using Tox 3.

@brianhelba brianhelba merged commit 841b991 into master Jan 30, 2025
3 checks passed
@brianhelba brianhelba deleted the dependency-groups branch January 30, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants