-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added --customIndexTemplate option #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-c
probably does not work because https://github.com/kiwix/kiwix-tools/pull/477/files#diff-29eedb326cc54203c610d3910176face715ff30664857e7d8ced287ff455551aL122 has not been modified.
@kelson42 sorry, it wasn't working when I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage is not aligned properly. I would probably call the option only --customIndex
.
If I give an invalid template file, then it should not start and print an appropriate error. For the moment, $ kiwix-serve --port=8080 --customIndexTemplate=phzh_core-greek-one_el_2020-12.zim phzh_core-greek-one_el_2020-12.zim
starts and gives a blanck index page.
Same remark for a non-existing path.
Same remark for non-readable file.
@kelson42 the error for the non-readable file should be propagated by |
@MananJethwani I don't know the code detail, but it should stop, not display a warning. Probably |
Agree with @kelson42 if the user pass a option and we cannot respect it, it should be a error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two really easy fix to do. But we are good.
This PR commits could be squash together in only one.
Need to kiwix/libkiwix#607 to be merged first.
6154e6c
to
d9a4fd8
Compare
d9a4fd8
to
5363da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are good.
To merge once kiwix/libkiwix#607 is merged.
5363da6
to
6a7c737
Compare
@kelson42 this PR will add --customIndexTemplate argument.
This depends on kiwix/libkiwix#607