Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary help message #1152

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Remove unnecessary help message #1152

merged 1 commit into from
Nov 30, 2020

Conversation

arghya88
Copy link
Contributor

@arghya88 arghya88 commented Nov 27, 2020 •
edited
Loading

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

  • Removes unnecessary help message introduced for machine readable outputs for commands which does not have -o url flag

Reference

Fixes #

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 27, 2020
knative-prow-robot
knative-prow-robot reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arghya88: 0 warnings.

In response to this:

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

  • Removes unnecessary help message introduced for machine readable outputs which does not have -o url flag

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2020
@arghya88
Copy link
Contributor Author

/cc @navidshaikh

@arghya88 arghya88 force-pushed the remove-help branch 3 times, most recently from 0240763 to 8762a7c Compare November 28, 2020 07:40
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/source/apiserver/describe.go 85.0% 84.7% -0.3
pkg/kn/commands/source/ping/describe.go 85.2% 84.9% -0.3
pkg/kn/commands/trigger/describe.go 83.3% 83.0% -0.4

navidshaikh
navidshaikh approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghya88, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@knative-prow-robot knative-prow-robot merged commit 3da8900 into knative:master Nov 30, 2020
@arghya88 arghya88 deleted the remove-help branch November 30, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@maximilien maximilien Awaiting requested review from maximilien

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arghya88 @knative-metrics-robot @knative-prow-robot @navidshaikh