Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop --strict flag on ko #1295

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Drop --strict flag on ko #1295

merged 1 commit into from
Apr 27, 2021

Conversation

markusthoemmes
Copy link
Contributor

As per title. Since ko-build/ko@6586a72 this has been the default and we recently updated ko in CI.

This fixes the nightly build.

/assign @rhuss @dsimansk

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 26, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2021
itsmurugappan
itsmurugappan approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@itsmurugappan itsmurugappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2021
@itsmurugappan
Copy link
Contributor

/test pull-knative-client-go-coverage

maximilien
maximilien approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 27, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsmurugappan, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@knative-prow-robot
Copy link
Contributor

@markusthoemmes: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-go-coverage d7ccc98 link /test pull-knative-client-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit 73f8219 into knative:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@itsmurugappan itsmurugappan itsmurugappan approved these changes

Assignees

@maximilien maximilien

@rhuss rhuss

@dsimansk dsimansk

@itsmurugappan itsmurugappan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusthoemmes @itsmurugappan @knative-prow-robot @maximilien @rhuss @dsimansk