Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niv-updater-action causes back references noise in nixpkgs #36

Closed
FRidh opened this issue Oct 7, 2020 · 3 comments
Closed

niv-updater-action causes back references noise in nixpkgs #36

FRidh opened this issue Oct 7, 2020 · 3 comments

Comments

@FRidh
Copy link

FRidh commented Oct 7, 2020

I recently noticed a lot of references to commits made using this updater action. While I totally see the value for users of the action, the noise can be really annoying for those being referenced. See e.g. (yes, I am creating some noise now myself) NixOS/nixpkgs#97586. As soon as this updater action starts to be used more the back references on the issues become useless.

This is perhaps not the right place to see this fixed, since in the end it is GitHub that adds the references, but practically speaking you are the only ones that can do anything about it.

@knl
Copy link
Owner

knl commented Oct 7, 2020

Hi @FRidh, thanks for reporting this. I thought I got it fixed with github_changelog_no_backreferences option (which defaults to true) -- it was raised in the issue #26 and fixed in Release 6: https://github.com/knl/niv-updater-action/releases/tag/v6

From what I see, the references are coming from people using versions older than v6. I'll ping them and ask to update.

@FRidh
Copy link
Author

FRidh commented Oct 7, 2020

Alright, thank you!

nomeata pushed a commit to nomeata/umklappbot that referenced this issue Oct 8, 2020
This PR is triggered by [this issue](knl/niv-updater-action#36) in niv-updater-action: The nixpkgs project is getting a lot of noise in their PRs due to GitHub placing back-references. This has been fixed in niv-updater-action v6.
knl added a commit that referenced this issue Jan 11, 2021
This is to reduce the backreferencing noise on nixpkgs: #36

Also, this is something people copy/paste, so better to have it up to date.
@knl
Copy link
Owner

knl commented Jan 11, 2021

I'm closing this issue since I've contacted everyone with the older version, and the last two release don't cause noise. Please reopen if you spot any issue.

@knl knl closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants