Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding a convenience function to deregister channel tokens. #17

Merged
merged 1 commit into from
Jan 8, 2024
Merged

feat: Adding a convenience function to deregister channel tokens. #17

merged 1 commit into from
Jan 8, 2024

Conversation

patrickhammond
Copy link
Collaborator

No description provided.

@linear Linear
Copy link

linear bot commented Dec 22, 2023

KNO-4927 Add convenience function for deregistering a push notification token

@github-actions GitHub Actions
Copy link

Coverage Report

Coverage after merging patrick-kno-4927-add-convenience-function-for-deregistering-a-push into main will be
52.29%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   api_client.dart74.58%100%100%74.58%143, 21, 33, 35, 37, 39–40, 42–43, 46, 48, 51–54
   feed_client.dart0%100%100%0%100, 102–104, 106, 112–114, 116–117, 123–125, 127–128, 134–135, 139, 141, 144–146, 149, 151, 158, 160–161, 163–164, 166–167, 169–170, 172–173, 175, 177–178, 183–184, 186–187, 190–191, 193, 195, 197–199, 206, 212–213, 217, 219–221, 223–224, 226–227, 230–231, 236–237, 242, 245, 249–251, 254–255, 261–262, 265, 270–271, 277–278, 280–282, 286–287, 290, 294, 297–298, 300–302, 306–307, 310, 314, 317–318, 320–322, 326–327, 330, 334, 337–338, 340–342, 346–347, 350, 354, 357–358, 360–362, 364–365, 370–371, 374, 378, 381–382, 384–386, 390–391, 394, 398, 401–402, 404–406, 41, 410, 413–414, 416–420, 423–424, 426–427, 431, 434–435, 437–441, 444–445, 447–448, 452, 455–456, 458–459, 46, 460–462, 465–466, 468–469, 47, 473, 476, 480–482, 487–488, 49, 491–493, 495–499, 50, 501–502, 504, 51, 510–512, 520–529, 533–539, 54, 540, 547–549, 57–58, 60–61, 86, 88, 90–92, 95–97
   knock.dart51.28%100%100%51.28%101, 104–105, 108, 112–113, 117–119, 122, 124, 62–64, 66, 93, 96–98
   preferences_client.dart5.26%100%100%5.26%14, 22, 24–26, 28, 30, 33–35, 37–38, 41–44, 47–48
   user_client.dart64.52%100%100%64.52%14–16, 18–19, 22, 30–32, 35–36, 39–40, 43–44, 47–48, 51–53, 56–57
lib/src/model
   api_response.dart87.50%100%100%87.50%27
   channel.dart100%100%100%100%
   feed.dart100%100%100%100%
   feed_options.dart100%100%100%100%
   preferences.dart100%100%100%100%
   recipient.dart100%100%100%100%
   user.dart91.30%100%100%91.30%66–67
   feed_extensions.dart100%100%100%100%
   feed_response.dart100%100%100%100%
   knock_object.dart100%100%100%100%
lib/src/util
   retry.dart100%100%100%100%
   date_time.dart100%100%100%100%
   arguments.dart0%100%100%0%7

cjbell
cjbell approved these changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@cjbell cjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one q, not blocking

lib/src/user_client.dart
@@ -119,4 +147,11 @@ extension _ChannelDataExtension on ChannelData {
data: data.copyWith(tokens: tokens),
);
}

ChannelData removeToken(String token) {
final tokens = List.of(data.tokens)..remove(token);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 is the double .. here correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Cascade notation. https://dart.dev/language/operators#cascade-notation

@patrickhammond patrickhammond merged commit 5d552c8 into main Jan 8, 2024
2 checks passed
@patrickhammond patrickhammond deleted the patrick-kno-4927-add-convenience-function-for-deregistering-a-push branch January 8, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjbell cjbell cjbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhammond @cjbell