Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNO-5878: Error with preference set #20

Merged
merged 2 commits into from
May 3, 2024

Conversation

matgar26
Copy link
Contributor

@matgar26 matgar26 commented May 3, 2024

https://linear.app/knock/issue/KNO-5878/%5Bflutter-sdk%5D-error-with-preference-sets

Fixed a bug with our parsing of PreferenceSet, specifically within our ChannelTypes and Categories

Copy link

linear bot commented May 3, 2024

@flodaniel
Copy link

I am the customer who reported the bug and can confirm that this PR fixes the issue. Using this branch as a dependency fixes the issue and the preference set can be parsed successfully. 👍

Copy link

github-actions bot commented May 3, 2024

Coverage Report

Coverage after merging matgar26/KNO-5878-error-with-preferenceSet into main will be
52.58%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   api_client.dart74.58%100%100%74.58%143, 21, 33, 35, 37, 39–40, 42–43, 46, 48, 51–54
   feed_client.dart0%100%100%0%100, 102–104, 106, 112–114, 116–117, 123–125, 127–128, 134–135, 139, 141, 144–146, 149, 151, 158, 160–161, 163–164, 166–167, 169–170, 172–173, 175, 177–178, 183–184, 186–187, 190–191, 193, 195, 197–199, 206, 212–213, 217, 219–221, 223–224, 226–227, 230–231, 236–237, 242, 245, 249–251, 254–255, 261–262, 265, 270–271, 277–278, 280–282, 286–287, 290, 294, 297–298, 300–302, 306–307, 310, 314, 317–318, 320–322, 326–327, 330, 334, 337–338, 340–342, 346–347, 350, 354, 357–358, 360–362, 364–365, 370–371, 374, 378, 381–382, 384–386, 390–391, 394, 398, 401–402, 404–406, 41, 410, 413–414, 416–420, 423–424, 426–427, 431, 434–435, 437–441, 444–445, 447–448, 452, 455–456, 458–459, 46, 460–462, 465–466, 468–469, 47, 473, 476, 480–482, 487–488, 49, 491–493, 495–499, 50, 501–502, 504, 51, 510–512, 520–529, 533–539, 54, 540, 547–549, 57–58, 60–61, 86, 88, 90–92, 95–97
   knock.dart51.28%100%100%51.28%101, 104–105, 108, 112–113, 117–119, 122, 124, 62–64, 66, 93, 96–98
   preferences_client.dart5.26%100%100%5.26%14, 22, 24–26, 28, 30, 33–35, 37–38, 41–44, 47–48
   user_client.dart64.52%100%100%64.52%14–16, 18–19, 22, 30–32, 35–36, 39–40, 43–44, 47–48, 51–53, 56–57
lib/src/model
   api_response.dart87.50%100%100%87.50%27
   channel.dart100%100%100%100%
   feed.dart100%100%100%100%
   feed_options.dart100%100%100%100%
   preferences.dart100%100%100%100%
   recipient.dart100%100%100%100%
   user.dart91.30%100%100%91.30%66–67
   feed_extensions.dart100%100%100%100%
   feed_response.dart100%100%100%100%
   knock_object.dart100%100%100%100%
lib/src/util
   retry.dart100%100%100%100%
   date_time.dart100%100%100%100%
   arguments.dart0%100%100%0%7

@matgar26 matgar26 merged commit 84c5bc6 into main May 3, 2024
2 checks passed
@matgar26
Copy link
Contributor Author

matgar26 commented May 3, 2024

I am the customer who reported the bug and can confirm that this PR fixes the issue. Using this branch as a dependency fixes the issue and the preference set can be parsed successfully. 👍

@flodaniel thanks for flagging this. This should now be merged in and included with version 0.1.4

@flodaniel
Copy link

Thank you @matgar26. When will version 0.1.4 ship to pub.dev?

@flodaniel
Copy link

Sorry to ping again but we need this bugfix to ship Knock to production. Do you think a publish to pub.dev is possible today? Otherwise we will use the github source directly as the ref. @cjbell @matgar26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants