Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't conform errors for swift 6 support #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: don't conform errors for swift 6 support #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40bbf2
fix: don't conform errors for swift 6 support
cjbell Sep 19, 2024
c008d4f
chore: cleanup
cjbell Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ios/Classes/KnockPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,15 @@ import Flutter
import UIKit
import Combine

extension FlutterError: Error {}
struct FlutterErrorWrapper: Error {
let flutterError: FlutterError
let message: String

init(flutterError: FlutterError) {
self.flutterError = flutterError
self.message = flutterError.message ?? "Unknown Flutter error"
}
}

public class KnockPlugin: NSObject, FlutterPlugin, KnockHostApi {
public static func register(with registrar: FlutterPluginRegistrar) {
Expand All @@ -15,7 +23,9 @@ public class KnockPlugin: NSObject, FlutterPlugin, KnockHostApi {
private let apnsTokenSubject = PassthroughSubject<Result<Data, Error>, Error>()

func getFcmToken(completion: @escaping (Result<String, Error>) -> Void) {
completion(.failure(FlutterError(code: "unsupported", message: "getFcmToken is not supported on iOS", details: nil)))
let flutterError = FlutterError(code: "unsupported", message: "getFcmToken is not supported on iOS", details: nil)

completion(.failure(FlutterErrorWrapper(flutterError: flutterError)))
}

func getApnsToken(completion: @escaping (Result<String, Error>) -> Void) {
Expand Down
Loading