Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distribute ES6 code in ES6 modules #52

Merged
merged 1 commit into from
Nov 27, 2020
Merged

distribute ES6 code in ES6 modules #52

merged 1 commit into from
Nov 27, 2020

Conversation

semmel
Copy link
Contributor

@semmel semmel commented Oct 22, 2020

Addresses #43.

  • saves 1KB in siriwave.esm.min.js (9279 bytes -> 8348 bytes)
  • better readable JS code in siriwave.esm.js

@semmel
Copy link
Contributor Author

semmel commented Nov 23, 2020

Is there anything I can do to bring this PR forward?

kopiro
kopiro approved these changes Nov 27, 2020
View reviewed changes
Copy link
Owner

@kopiro kopiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm gonna publishing just right now

@kopiro kopiro merged commit 30e5322 into kopiro:master Nov 27, 2020
@kopiro
Copy link
Owner

kopiro commented Nov 27, 2020

v2.0.4 includes your changes!

@semmel
Copy link
Contributor Author

semmel commented Dec 1, 2020

@kopiro Fantastic! Thanks a lot! 🤩

@semmel semmel deleted the compile-to-es6-module branch December 2, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopiro kopiro kopiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semmel @kopiro