-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using java.awt.Color #5
Comments
HopeBaron
added a commit
that referenced
this issue
Jun 17, 2020
HopeBaron
added a commit
that referenced
this issue
Jun 20, 2020
HopeBaron
added a commit
that referenced
this issue
Jun 20, 2020
HopeBaron
added a commit
that referenced
this issue
Jun 28, 2020
HopeBaron
added a commit
that referenced
this issue
Jul 8, 2020
HopeBaron
added a commit
that referenced
this issue
Jul 10, 2020
HopeBaron
added a commit
that referenced
this issue
Aug 21, 2020
HopeBaron
added a commit
that referenced
this issue
Oct 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kord uses
java.awt.Color
to represent colors. This issue suggests moving to our own/a multiplatform implementation.Why switch from java's implementation
java.desktop
module for what in our use case is a glorified integer. It comes down to ~30 megabytes which would be nice to shave off.Color
regardless (or risk depending on an npm module!). We might as well make one that fits all platforms.Isn't this outside of Kord's scope
It is, technically, outside of our scope. A color class is not related to the Discord API. A simple
Color(r,g,b)
should be sufficient though. The alternative would be to just accept an integer, which would be a dramatically worse user experience.Issue originally made by @BartArys
The text was updated successfully, but these errors were encountered: