Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper to string conversion #165

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Proper to string conversion #165

merged 2 commits into from
Jan 11, 2021

Conversation

HopeBaron
Copy link
Member

No description provided.

@HopeBaron HopeBaron requested a review from BartArys January 11, 2021 21:01
@BartArys
Copy link
Contributor

Not that I disapprove of the changes, but why were some orNull variants removed but not others? I've got my own conclusions but I'd like to hear yours

@HopeBaron
Copy link
Member Author

Not that I disapprove of the changes, but why were some orNull variants removed but not others? I've got my own conclusions but I'd like to hear yours

if we changed to value.toString() in which case the returned string will always be present, we can't have both OrNull variants for snowflakes and String

@HopeBaron HopeBaron merged commit 637b479 into 0.7.x Jan 11, 2021
@HopeBaron HopeBaron deleted the fixes/0.7.x/option-string-conversion branch March 11, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartArys BartArys BartArys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HopeBaron @BartArys