Provide the same functions of Permissions to MessageFlags #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartArys
reviewed
Mar 6, 2021
There was a problem hiding this comment.
I missed this during the initial review, but why is MessageFlags a data class? We hide the constructor behind an internal keyword but we still expose the autogenerated copy method.
Additionally, the autogenerated tostring isn't really useful here either. Returning a tostring with the flags would be of more use to those trying to debug.
Good catch, will work on it |
BartArys
reviewed
Mar 9, 2021
Co-authored-by: Bart Arys <[email protected]>
BartArys
approved these changes
Mar 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.