Add ResolvedChannel #225
Merged
Add ResolvedChannel #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support to resolved channels by application commands
BartArys
reviewed
Mar 29, 2021
|
|
||
| override val supplier: EntitySupplier | ||
| get() = strategy.supply(kord) | ||
|
|
There was a problem hiding this comment.
Should add a meaningful toString
There was a problem hiding this comment.
Should we add the object reference for the type, or it's value (Discord value) Although the object gives better idea of the actual type. However the value is less complicated than this:
Type: dev.kord.common.entity.ChannelType$GuildCategory@47e3a62bThere was a problem hiding this comment.
We should probably just give those types a better toString as well, though that's not the scope of this PR
BartArys
approved these changes
Mar 29, 2021
BartArys
approved these changes
Mar 29, 2021
|
|
||
| override val supplier: EntitySupplier | ||
| get() = strategy.supply(kord) | ||
|
|
There was a problem hiding this comment.
We should probably just give those types a better toString as well, though that's not the scope of this PR
Co-authored-by: Bart Arys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support to resolved channels by application commands