Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oversights in forms support #543

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix oversights in forms support #543

merged 2 commits into from
Feb 24, 2022

Conversation

lukellmann
Copy link
Member

@lukellmann lukellmann commented Feb 21, 2022 •
edited
Loading

  • default builder in ActionRowBuilder.textInput()
  • ComponentBuilder.build() returns different types
  • add command and focusedOption to AutoCompleteInteraction

@lukellmann lukellmann changed the title Default TextInputBuilder, polymorphic DiscordComponent types Fix oversights in forms support Feb 23, 2022
@HopeBaron
Copy link
Member

Any more edits in mind? I liked the focused option addition 👍

@lukellmann
Copy link
Member Author

Can't think of one rn.

@HopeBaron
Copy link
Member

Will be merged then

@HopeBaron HopeBaron merged commit 0d1003d into kordlib:0.8.x Feb 24, 2022
@lukellmann lukellmann deleted the fixes/component-builders branch February 25, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HopeBaron HopeBaron HopeBaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukellmann @HopeBaron