Add feature variant for voice #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DRSchlaubi
commented
May 5, 2022
DRSchlaubi
commented
- Fix Make an extra artifact for voice #439
HopeBaron
reviewed
May 13, 2022
| dependencies { | ||
| implementation("dev.kord", "core", "<version>") { | ||
| capabilities { | ||
| requireCapability("dev.kord:core-voice:<version>") |
There was a problem hiding this comment.
core-voice?
thought it was just voice
There was a problem hiding this comment.
This is a variant of core, including voice, the normal voice module remains
|
This already got merged and I don't know anything about gradle feature variants, but why is the config in the |
It's like the bomb, this kinda tooling is part of gradles java tooling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.