Fix deprecation propagation for new select menus #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecations for SelectMenuBuilder.options and SelectMenuComponent.options were propagated to the overrides in StringSelectBuilder and StringSelectComponent when a user of Kord didn't have progressive mode enabled. To fix this, extensions are provided instead. The changes in the public API are binary incompatible compared to #707 but not compared to 0.8.0-M17 so only snapshot users can be affected. see #707, https://youtrack.jetbrains.com/issue/KT-47902 and https://discord.com/channels/556525343595298817/587324906702766226/1042799716745879643
lukellmann
added a commit
that referenced
this pull request
Nov 23, 2022
@LowPriorityInOverloadResolution is required so that the replacement for SelectMenuComponent.options works correctly. This was simply forgotten in #721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecations for
SelectMenuBuilder.optionsandSelectMenuComponent.optionswere propagated to the overrides inStringSelectBuilderandStringSelectComponentwhen a user of Kord didn't have progressive mode enabled.To fix this, extensions are provided instead.
The changes in the public API are binary incompatible compared to #707 but not compared to 0.8.0-M17 so only snapshot users can be affected.
see #707, https://youtrack.jetbrains.com/issue/KT-47902 and https://discord.com/channels/556525343595298817/587324906702766226/1042799716745879643