Fix nonce deserialization for big integers #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While #632 already fixed some cases in which the nonce field of a message couldn't be deserialized, we were made aware of cases where the integer received for that field didn't fit into the range of an Int, resulting in a NumberFormatException. see https://discord.com/channels/556525343595298817/1074993316220895302
NoComment1105
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #632 already fixed some cases in which the
noncefield of a message couldn't be deserialized, we were made aware of cases where the integer received for that field didn't fit into the range of anInt, resulting in aNumberFormatException.see https://discord.com/channels/556525343595298817/1074993316220895302