Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for #743 #781

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Conversation

lukellmann
Copy link
Member

  • rename GuildFeature.CreatorMonetizableProvision to GuildFeature.CreatorMonetizableProvisional

  • deprecate GuildFeature.MonetizationEnabled, see Document role subscriptions discord/discord-api-docs#5724 (comment)

  • add @SerialName for DiscordRoleTags.botId

  • add RoleTags.isLinkedRole

  • fix DiscordMessage.roleSubscriptionData nullability

  • fix KDocs

see discord/discord-api-docs#5724 and discord/discord-api-docs#5828

* rename GuildFeature.CreatorMonetizableProvision to
  GuildFeature.CreatorMonetizableProvisional

* deprecate GuildFeature.MonetizationEnabled, see
  discord/discord-api-docs#5724 (comment)

* add @SerialName for DiscordRoleTags.botId

* add RoleTags.isLinkedRole

* fix DiscordMessage.roleSubscriptionData nullability

* fix KDocs

see discord/discord-api-docs#5724 and
discord/discord-api-docs#5828
@lukellmann
Copy link
Member Author

can you take a look at this @NoComment1105?

Copy link
Contributor

@NoComment1105 NoComment1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn that was bad pr I did. Just one comment

@lukellmann
Copy link
Member Author

Damn that was bad pr I did.

nah, mostly minor things

@lukellmann lukellmann requested a review from NoComment1105 March 4, 2023 19:57
@lukellmann lukellmann merged commit a788bfc into kordlib:0.8.x Mar 5, 2023
@lukellmann lukellmann deleted the 743-corrections branch March 5, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants