Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes and bugs before release #793

Merged
merged 43 commits into from
Mar 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
bf59ab9
fix builders
HopeBaron Mar 24, 2023
1f38129
apiDump
HopeBaron Mar 24, 2023
e26d35e
Apply params
HopeBaron Mar 24, 2023
2845e4c
Fix ambiguity by removing default builder argument
lukellmann Mar 24, 2023
319450d
Dump API
lukellmann Mar 24, 2023
b5e238d
Fix forum incompatibilities in core
lukellmann Mar 24, 2023
129847d
Fix integration issues in core
lukellmann Mar 24, 2023
b9fe4cb
Fix test
lukellmann Mar 24, 2023
4cc0397
Remove unnecessary overrides
lukellmann Mar 24, 2023
6950265
Emit ForumChannel events
lukellmann Mar 24, 2023
bbb8397
Fix nullability of some fields
lukellmann Mar 24, 2023
3ef7e1f
Use plain List for MultipartStartThreadRequest
lukellmann Mar 24, 2023
e78fdd2
Remove unused DiscordIntegrations
lukellmann Mar 24, 2023
71dcede
Use core Integration for events
lukellmann Mar 24, 2023
98ed6f9
Don't cache Audit Log Entries
lukellmann Mar 24, 2023
46846e1
Remove wrong SerialName annotation for components
lukellmann Mar 24, 2023
09f55ff
Reintroduce old constructor of StartThreadWithMessageBuilder
lukellmann Mar 24, 2023
5fdf2af
Rename StartThreadWithoutMessageBuilder back to StartThreadBuilder
lukellmann Mar 24, 2023
2334b09
Missing API Dump
lukellmann Mar 24, 2023
643a45b
Remove Forum Tag routes
lukellmann Mar 24, 2023
5b5bac0
Make GuildMemberFlags serializer internal
lukellmann Mar 24, 2023
aeb5cb7
Override methods in ForumChannel and ForumChannelBehavior
lukellmann Mar 24, 2023
e40114a
Dump API
lukellmann Mar 24, 2023
95a0eca
Consider ForumChannel events in enableEvent
lukellmann Mar 24, 2023
dba13c0
Move webhooks to CategorizableChannelBehavior
lukellmann Mar 25, 2023
eed9f3b
Rename DiscordForumTag to ForumTag
lukellmann Mar 25, 2023
afdf76f
Fix some optionalities and nullabilities
lukellmann Mar 25, 2023
1c4deab
Remove unnecessary ThreadParentChannelBehavior supertype
lukellmann Mar 25, 2023
2297364
Changes to ForumTagBuilder
lukellmann Mar 25, 2023
df2b775
Clarify name of ThreadParentChannelBehavior.unsafeStartThread
lukellmann Mar 25, 2023
f9b2448
Fix mistake in replacement
lukellmann Mar 25, 2023
4193815
Align order with intents documentation
lukellmann Mar 25, 2023
b2f0713
Rename DiscordDefaultReaction to DefaultReaction
lukellmann Mar 25, 2023
568176e
Add missing properties to ForumChannel and TextChannel
lukellmann Mar 25, 2023
28919a1
Update message count caching
lukellmann Mar 25, 2023
2830dc4
Merge branch '0.8.x' into 0.8.0-fixes
lukellmann Mar 25, 2023
0044885
Add changelog entry
lukellmann Mar 25, 2023
107ddab
Remove default value for builder
lukellmann Mar 25, 2023
1a7d5db
Add ThreadChannel.totalMessageSent
lukellmann Mar 25, 2023
fe93574
Align order with intents documentation
lukellmann Mar 25, 2023
15cc326
Remove ThreadModifyBuilder
lukellmann Mar 25, 2023
243cf61
Make StartForumThreadBuilder.message non-nullable
lukellmann Mar 25, 2023
38a347c
ChannelService.startThread builder parameter was unused
lukellmann Mar 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* Make `Snowflake`'s ordering consistent with `equals` (by @Lukellmann in #773)
* Fix various bugs in `DiscordBitSet` (by @Lukellmann in #772)
* Use 74 byte ip discovery packet instead of the deprecated 70 byte discovery packet (by @lost-illusi0n in #776)
* Fix breaking changes and bugs before release (by @Lukellmann in #793)

## Dependencies

Expand Down
143 changes: 69 additions & 74 deletions common/api/common.api
Original file line number Diff line number Diff line change
Expand Up @@ -1917,6 +1917,37 @@ public final class dev/kord/common/entity/DefaultMessageNotificationLevel$Unknow
public fun <init> (I)V
}

public final class dev/kord/common/entity/DefaultReaction {
public static final field Companion Ldev/kord/common/entity/DefaultReaction$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
public fun <init> (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;)V
public final fun component1 ()Ldev/kord/common/entity/Snowflake;
public final fun component2 ()Ljava/lang/String;
public final fun copy (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;)Ldev/kord/common/entity/DefaultReaction;
public static synthetic fun copy$default (Ldev/kord/common/entity/DefaultReaction;Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ILjava/lang/Object;)Ldev/kord/common/entity/DefaultReaction;
public fun equals (Ljava/lang/Object;)Z
public final fun getEmojiId ()Ldev/kord/common/entity/Snowflake;
public final fun getEmojiName ()Ljava/lang/String;
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
public static final fun write$Self (Ldev/kord/common/entity/DefaultReaction;Lkotlinx/serialization/encoding/CompositeEncoder;Lkotlinx/serialization/descriptors/SerialDescriptor;)V
}

public final class dev/kord/common/entity/DefaultReaction$$serializer : kotlinx/serialization/internal/GeneratedSerializer {
public static final field INSTANCE Ldev/kord/common/entity/DefaultReaction$$serializer;
public fun childSerializers ()[Lkotlinx/serialization/KSerializer;
public fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ldev/kord/common/entity/DefaultReaction;
public synthetic fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ljava/lang/Object;
public fun getDescriptor ()Lkotlinx/serialization/descriptors/SerialDescriptor;
public fun serialize (Lkotlinx/serialization/encoding/Encoder;Ldev/kord/common/entity/DefaultReaction;)V
public synthetic fun serialize (Lkotlinx/serialization/encoding/Encoder;Ljava/lang/Object;)V
public fun typeParametersSerializers ()[Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DefaultReaction$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DeletedMessage {
public static final field Companion Ldev/kord/common/entity/DeletedMessage$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/optional/OptionalSnowflake;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
Expand Down Expand Up @@ -3074,37 +3105,6 @@ public final class dev/kord/common/entity/DiscordConnectionVisibility$Unknown :
public fun <init> (I)V
}

public final class dev/kord/common/entity/DiscordDefaultReaction {
public static final field Companion Ldev/kord/common/entity/DiscordDefaultReaction$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
public fun <init> (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;)V
public final fun component1 ()Ldev/kord/common/entity/Snowflake;
public final fun component2 ()Ljava/lang/String;
public final fun copy (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;)Ldev/kord/common/entity/DiscordDefaultReaction;
public static synthetic fun copy$default (Ldev/kord/common/entity/DiscordDefaultReaction;Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ILjava/lang/Object;)Ldev/kord/common/entity/DiscordDefaultReaction;
public fun equals (Ljava/lang/Object;)Z
public final fun getEmojiId ()Ldev/kord/common/entity/Snowflake;
public final fun getEmojiName ()Ljava/lang/String;
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
public static final fun write$Self (Ldev/kord/common/entity/DiscordDefaultReaction;Lkotlinx/serialization/encoding/CompositeEncoder;Lkotlinx/serialization/descriptors/SerialDescriptor;)V
}

public final class dev/kord/common/entity/DiscordDefaultReaction$$serializer : kotlinx/serialization/internal/GeneratedSerializer {
public static final field INSTANCE Ldev/kord/common/entity/DiscordDefaultReaction$$serializer;
public fun childSerializers ()[Lkotlinx/serialization/KSerializer;
public fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ldev/kord/common/entity/DiscordDefaultReaction;
public synthetic fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ljava/lang/Object;
public fun getDescriptor ()Lkotlinx/serialization/descriptors/SerialDescriptor;
public fun serialize (Lkotlinx/serialization/encoding/Encoder;Ldev/kord/common/entity/DiscordDefaultReaction;)V
public synthetic fun serialize (Lkotlinx/serialization/encoding/Encoder;Ljava/lang/Object;)V
public fun typeParametersSerializers ()[Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DiscordDefaultReaction$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DiscordDeletedGuildRole {
public static final field Companion Ldev/kord/common/entity/DiscordDeletedGuildRole$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ldev/kord/common/entity/Snowflake;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
Expand Down Expand Up @@ -3482,43 +3482,6 @@ public final class dev/kord/common/entity/DiscordEmoji$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DiscordForumTag {
public static final field Companion Ldev/kord/common/entity/DiscordForumTag$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
public fun <init> (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;)V
public final fun component1 ()Ldev/kord/common/entity/Snowflake;
public final fun component2 ()Ljava/lang/String;
public final fun component3 ()Z
public final fun component4 ()Ldev/kord/common/entity/Snowflake;
public final fun component5 ()Ljava/lang/String;
public final fun copy (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;)Ldev/kord/common/entity/DiscordForumTag;
public static synthetic fun copy$default (Ldev/kord/common/entity/DiscordForumTag;Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;ILjava/lang/Object;)Ldev/kord/common/entity/DiscordForumTag;
public fun equals (Ljava/lang/Object;)Z
public final fun getEmojiId ()Ldev/kord/common/entity/Snowflake;
public final fun getEmojiName ()Ljava/lang/String;
public final fun getId ()Ldev/kord/common/entity/Snowflake;
public final fun getModerated ()Z
public final fun getName ()Ljava/lang/String;
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
public static final fun write$Self (Ldev/kord/common/entity/DiscordForumTag;Lkotlinx/serialization/encoding/CompositeEncoder;Lkotlinx/serialization/descriptors/SerialDescriptor;)V
}

public final class dev/kord/common/entity/DiscordForumTag$$serializer : kotlinx/serialization/internal/GeneratedSerializer {
public static final field INSTANCE Ldev/kord/common/entity/DiscordForumTag$$serializer;
public fun childSerializers ()[Lkotlinx/serialization/KSerializer;
public fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ldev/kord/common/entity/DiscordForumTag;
public synthetic fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ljava/lang/Object;
public fun getDescriptor ()Lkotlinx/serialization/descriptors/SerialDescriptor;
public fun serialize (Lkotlinx/serialization/encoding/Encoder;Ldev/kord/common/entity/DiscordForumTag;)V
public synthetic fun serialize (Lkotlinx/serialization/encoding/Encoder;Ljava/lang/Object;)V
public fun typeParametersSerializers ()[Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DiscordForumTag$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/DiscordGuild {
public static final field Companion Ldev/kord/common/entity/DiscordGuild$Companion;
public synthetic fun <init> (IILdev/kord/common/entity/Snowflake;Ljava/lang/String;Ljava/lang/String;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/OptionalBoolean;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/optional/Optional;Ljava/lang/String;Ldev/kord/common/entity/Snowflake;Lkotlin/time/Duration;Ldev/kord/common/entity/optional/OptionalBoolean;Ldev/kord/common/entity/optional/OptionalSnowflake;Ldev/kord/common/entity/VerificationLevel;Ldev/kord/common/entity/DefaultMessageNotificationLevel;Ldev/kord/common/entity/ExplicitContentFilter;Ljava/util/List;Ljava/util/List;Ljava/util/List;Ldev/kord/common/entity/MFALevel;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/SystemChannelFlags;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/OptionalBoolean;Ldev/kord/common/entity/optional/OptionalBoolean;Ldev/kord/common/entity/optional/OptionalInt;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/OptionalInt;Ldev/kord/common/entity/optional/OptionalInt;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ldev/kord/common/entity/PremiumTier;Ldev/kord/common/entity/optional/OptionalInt;Ljava/lang/String;Ldev/kord/common/entity/Snowflake;Ldev/kord/common/entity/optional/OptionalInt;Ldev/kord/common/entity/optional/OptionalInt;Ldev/kord/common/entity/optional/OptionalInt;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/NsfwLevel;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;Ldev/kord/common/entity/optional/Optional;ZLkotlinx/serialization/internal/SerializationConstructorMarker;Lkotlin/jvm/internal/DefaultConstructorMarker;)V
Expand Down Expand Up @@ -6345,6 +6308,43 @@ public final class dev/kord/common/entity/ForumLayoutType$Unknown : dev/kord/com
public fun <init> (I)V
}

public final class dev/kord/common/entity/ForumTag {
public static final field Companion Ldev/kord/common/entity/ForumTag$Companion;
public synthetic fun <init> (ILdev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;Lkotlinx/serialization/internal/SerializationConstructorMarker;)V
public fun <init> (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;)V
public final fun component1 ()Ldev/kord/common/entity/Snowflake;
public final fun component2 ()Ljava/lang/String;
public final fun component3 ()Z
public final fun component4 ()Ldev/kord/common/entity/Snowflake;
public final fun component5 ()Ljava/lang/String;
public final fun copy (Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;)Ldev/kord/common/entity/ForumTag;
public static synthetic fun copy$default (Ldev/kord/common/entity/ForumTag;Ldev/kord/common/entity/Snowflake;Ljava/lang/String;ZLdev/kord/common/entity/Snowflake;Ljava/lang/String;ILjava/lang/Object;)Ldev/kord/common/entity/ForumTag;
public fun equals (Ljava/lang/Object;)Z
public final fun getEmojiId ()Ldev/kord/common/entity/Snowflake;
public final fun getEmojiName ()Ljava/lang/String;
public final fun getId ()Ldev/kord/common/entity/Snowflake;
public final fun getModerated ()Z
public final fun getName ()Ljava/lang/String;
public fun hashCode ()I
public fun toString ()Ljava/lang/String;
public static final fun write$Self (Ldev/kord/common/entity/ForumTag;Lkotlinx/serialization/encoding/CompositeEncoder;Lkotlinx/serialization/descriptors/SerialDescriptor;)V
}

public final class dev/kord/common/entity/ForumTag$$serializer : kotlinx/serialization/internal/GeneratedSerializer {
public static final field INSTANCE Ldev/kord/common/entity/ForumTag$$serializer;
public fun childSerializers ()[Lkotlinx/serialization/KSerializer;
public fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ldev/kord/common/entity/ForumTag;
public synthetic fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ljava/lang/Object;
public fun getDescriptor ()Lkotlinx/serialization/descriptors/SerialDescriptor;
public fun serialize (Lkotlinx/serialization/encoding/Encoder;Ldev/kord/common/entity/ForumTag;)V
public synthetic fun serialize (Lkotlinx/serialization/encoding/Encoder;Ljava/lang/Object;)V
public fun typeParametersSerializers ()[Lkotlinx/serialization/KSerializer;
}

public final class dev/kord/common/entity/ForumTag$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

public abstract class dev/kord/common/entity/GuildFeature {
public static final field Companion Ldev/kord/common/entity/GuildFeature$Companion;
public synthetic fun <init> (Ljava/lang/String;Lkotlin/jvm/internal/DefaultConstructorMarker;)V
Expand Down Expand Up @@ -6515,12 +6515,7 @@ public final class dev/kord/common/entity/GuildMemberFlags {
public fun toString ()Ljava/lang/String;
}

public final class dev/kord/common/entity/GuildMemberFlags$Companion : kotlinx/serialization/KSerializer {
public fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ldev/kord/common/entity/GuildMemberFlags;
public synthetic fun deserialize (Lkotlinx/serialization/encoding/Decoder;)Ljava/lang/Object;
public fun getDescriptor ()Lkotlinx/serialization/descriptors/SerialDescriptor;
public fun serialize (Lkotlinx/serialization/encoding/Encoder;Ldev/kord/common/entity/GuildMemberFlags;)V
public synthetic fun serialize (Lkotlinx/serialization/encoding/Encoder;Ljava/lang/Object;)V
public final class dev/kord/common/entity/GuildMemberFlags$Companion {
public final fun serializer ()Lkotlinx/serialization/KSerializer;
}

Expand Down
8 changes: 4 additions & 4 deletions common/src/main/kotlin/entity/DiscordChannel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ public data class DiscordChannel(
@SerialName("total_message_sent")
val totalMessageSent: OptionalInt = OptionalInt.Missing,
@SerialName("available_tags")
val availableTags: Optional<List<DiscordForumTag>> = Optional.Missing(),
val availableTags: Optional<List<ForumTag>> = Optional.Missing(),
@SerialName("applied_tags")
val appliedTags: Optional<List<Snowflake>> = Optional.Missing(),
@SerialName("default_reaction_emoji")
val defaultReactionEmoji: Optional<DiscordDefaultReaction?> = Optional.Missing(),
val defaultReactionEmoji: Optional<DefaultReaction?> = Optional.Missing(),
@SerialName("default_thread_rate_limit_per_user")
val defaultThreadRateLimitPerUser: Optional<DurationInSeconds> = Optional.Missing(),
@SerialName("default_sort_order")
Expand Down Expand Up @@ -332,15 +332,15 @@ public sealed class ArchiveDuration(
}

@Serializable
public data class DiscordDefaultReaction(
public data class DefaultReaction(
@SerialName("emoji_id")
val emojiId: Snowflake?,
@SerialName("emoji_name")
val emojiName: String?,
)

@Serializable
public data class DiscordForumTag(
public data class ForumTag(
val id: Snowflake,
val name: String,
val moderated: Boolean,
Expand Down
4 changes: 2 additions & 2 deletions common/src/main/kotlin/entity/Member.kt
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ public data class DiscordThreadMember(
val flags: Int
)

@Serializable(with = GuildMemberFlags.Companion::class)
@Serializable(with = GuildMemberFlags.Serializer::class)
public data class GuildMemberFlags(val code: Int) {

public operator fun contains(flag: GuildMemberFlags): Boolean {
return this.code and flag.code == flag.code
}

public companion object : KSerializer<GuildMemberFlags> {
internal object Serializer : KSerializer<GuildMemberFlags> {

override val descriptor: SerialDescriptor
get() = PrimitiveSerialDescriptor("flags", PrimitiveKind.INT)
Expand Down
Loading