Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster name is hardcoded as cluster.local #1021

Closed
ecusnir opened this issue May 26, 2022 · 3 comments · Fixed by #1031
Closed

Cluster name is hardcoded as cluster.local #1021

ecusnir opened this issue May 26, 2022 · 3 comments · Fixed by #1031
Labels
bug Something isn't working

Comments

@ecusnir
Copy link

ecusnir commented May 26, 2022

Describe the bug:
Since PR #894 the cluster name has been hardcoded as cluster.local, causing problems if this is not the actual name.

Expected behaviour:
Cluster name should be configurable and not hardcoded.

@ecusnir ecusnir added the bug Something isn't working label May 26, 2022
@aslafy-z
Copy link
Collaborator

What do you think of removing the cluster domain name altogether and letting the dns provider take care of routing the the right place instead of allowing it to be customized?

@ecusnir @ahma @siliconbrain

@siliconbrain
Copy link
Contributor

siliconbrain commented Jul 26, 2022

@aslafy-z I'm not sure this is feasible in all cases, like with a service mesh or other multi-cluster setup. I agree with @ecusnir, the cluster name/domain should be configurable.

@ecusnir
Copy link
Author

ecusnir commented Jul 27, 2022

I believe this is how it used to be and it worked well in my case. However, I agree with @siliconbrain that it should be configurable since the code has changed and I don’t see a reason to go back to the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants