fix: allow customizing cluster domain #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
commented
Jun 8, 2022
aslafy-z
commented
Jun 8, 2022
aslafy-z
changed the title
|
I'm only vaguely familiar with how DNS resolution works when the cluster domain is not specified. I know it works in most cases, but I'm sure there are some edge cases e.g. maybe with a service mesh (e.g. Istio) or other multi-cluster setup. Also, the trailing dot that we leave in the generated domain name if cluster domain is defined as |
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
baf657b to
fbefee2
Compare
aslafy-z
commented
Jul 27, 2022
aslafy-z
commented
Jul 27, 2022
aslafy-z
commented
Jul 27, 2022
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
2 times, most recently
from
db08a05 to
116af7a
Compare
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
3 times, most recently
from
b31b213 to
53a529b
Compare
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
53a529b to
64ea30d
Compare
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
64ea30d to
3fbe3c7
Compare
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
3 times, most recently
from
7a727c6 to
549a1d9
Compare
ahma
requested review from
tarokkk,
bshifter and
siliconbrain
and removed request for
siliconbrain
siliconbrain
reviewed
Sep 8, 2022
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
2 times, most recently
from
b73b12e to
d87bd2e
Compare
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
d87bd2e to
98c6a07
Compare
|
@siliconbrain I think I addresses all the comments you left. Please have another check. |
ahma
requested review from
siliconbrain
and removed request for
siliconbrain
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
98c6a07 to
4e0b77c
Compare
Signed-off-by: GitHub <[email protected]>
aslafy-z
force-pushed
the
aslafy-z-patch-1
branch
from
4e0b77c to
bdf875d
Compare
ahma
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Enable users to customize cluster domain
Checklist
To Do