Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer without chunk key #1014

Merged
merged 2 commits into from
May 25, 2022
Merged

Buffer without chunk key #1014

merged 2 commits into from
May 25, 2022

Conversation

ahma
Copy link
Contributor

@ahma ahma commented May 20, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #961
License Apache 2.0

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@ahma ahma requested review from siliconbrain, tarokkk and bshifter May 20, 2022 14:54
@ahma ahma force-pushed the feature/no_bufferkey_support branch from 2c550eb to 513b9a3 Compare May 21, 2022 20:06
siliconbrain
siliconbrain previously approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@siliconbrain siliconbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahma ahma force-pushed the feature/no_bufferkey_support branch from 513b9a3 to 0b45afe Compare May 25, 2022 06:40
@ahma ahma merged commit 0ca75c2 into master May 25, 2022
@ahma ahma deleted the feature/no_bufferkey_support branch May 25, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z approved these changes

@bshifter bshifter bshifter approved these changes

@siliconbrain siliconbrain siliconbrain left review comments

@tarokkk tarokkk Awaiting requested review from tarokkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create buffer with no chunk key
4 participants
@ahma @siliconbrain @aslafy-z @bshifter