Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow containerOverrides for eventtailer and hosttailer to be set from logging-operator-logging values. #1032

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

hpdvanwyk
Copy link
Contributor

@hpdvanwyk hpdvanwyk commented Jun 9, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

This allows eventTailer and hostTailer container defaults to be overridden when using the logging-operator-logging chart values.yaml.

Why?

This is useful for overriding images for these pods for instance when running in an air gapped
environment.

Checklist

This allows eventtailer and hosttailer container defaults to be overridden
from the logging-operator-logging chart values.yaml. This is especially
useful for overriding images.
@ahma ahma requested review from bshifter and ahma June 14, 2022 10:03
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hpdvanwyk :LGTM

@ahma ahma merged commit 632f109 into kube-logging:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants